Fix test cases in `test_get_ordered_cycle_all_node_cycles ` (issue #71)

Becksteinlab / kda

Python package used for the analysis of biochemical kinetic diagrams.

GNU General Public License v3.0

3 stars 1 forks source link

Fix test cases in `test_get_ordered_cycle_all_node_cycles ` (issue #71) #73

Closed nawtrey closed 11 months ago

nawtrey commented 11 months ago

Description

Fixes #71
Updates test_get_ordered_cycle_all_node_cycles to switch test cycles based on python version due to changes in upstream NetworkX code

nawtrey commented 11 months ago

It looks like my local Python 3.8 environment was not sufficiently updated to trip the CycleError. I'll see if I can nail down the NetworkX version that breaks this test.

nawtrey commented 11 months ago

Updating from NetworkX v3.0 to 3.1 broke the test locally. I'm guessing it has to do with some algorithmic change in this PR. I'll try updating the test to check the networkx version instead.

nawtrey commented 11 months ago

Alright, simple change and tests are now passing. Merging.