Becksteinlab / kda

Python package used for the analysis of biochemical kinetic diagrams.
GNU General Public License v3.0
3 stars 1 forks source link

ENH, API: Remove "key" and "name" parameters #84

Closed nawtrey closed 2 months ago

nawtrey commented 2 months ago

Description

Status

nawtrey commented 2 months ago

The codecov report failed to run. Looking at the logs it looks like it failed due to hitting the "rate limit":

{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 723s.', code='throttled')}{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 721s.', code='throttled')}{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 719s.', code='throttled')}{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 717s.', code='throttled')}{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 715s.', code='throttled')}{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 712s.', code='throttled')}

It looks like this can be fixed by adding the codecov token to the repo and updating the YAML to snag it (see this comment and the codecov documentation).

I've already added the secret so I'll go ahead and open a new PR to update the YAML.

nawtrey commented 2 months ago

Okay, now that codecov is back online I can confirm the function graph_utils.generate_K_string_matrix is completely uncovered. I think this can now be removed since we no longer need to worry about creating the kij's as strings.

nawtrey commented 2 months ago

The only thing left to do would be to update the root README, but that'll get completely rewritten in #83 so I'll leave that for now.