search

Becksteinlab / kda

Python package used for the analysis of biochemical kinetic diagrams.
GNU General Public License v3.0
3 stars 1 forks source link

Revert "MAINT, API: Remove "key" and "name" parameters (#84)" #86

Closed nawtrey closed 1 month ago

nawtrey commented 1 month ago

Description

nawtrey commented 1 month ago

I'm walking back PR #84 for a few reasons:

  1. the parameters removed are used in the KDA paper and thus should remain working for a while
  2. If the parameters are to be removed, they should instead be deprecated first
  3. After discussion with Oliver, it seems we may decide to keep the key/name split, or at least a similar structure moving forward. The details will be discussed and addressed in PR #83.