search

Bedrock-OSS / regolith

Bedrock Addons compiler pipeline.
https://bedrock-oss.github.io/regolith/
MIT License
56 stars 17 forks source link

No support for filters hosted on GitLab #251

Closed MeItsLars closed 1 year ago

MeItsLars commented 1 year ago

Observation: Regolith doesn't support the downloading of filters that are hosted on a GitLab instance (both public and private repositories

Problem: This seems to be caused by the construction of the download URL, which is done as follows: url := fmt.Sprintf("%s//%s?ref=%s", f.Url, f.Id, repoVersion)

Proposed solution: Might be a bit tricky, because just including a check like: if url contains 'gitlab': ... is not really the way to go. More in-depth analysis is required.

stirante commented 1 year ago

Seems like a lot of issues can be fixed by forcing the protocol https://github.com/hashicorp/go-getter#forced-protocol

stirante commented 1 year ago

It might've been fixed in https://github.com/Bedrock-OSS/regolith/commit/dc0734428f1e8b3d0cc4b9e4bb11312f55288c8a Please let me know whether it works on this commit.

stirante commented 1 year ago

Closing due to inactivity