search

BedrockStreaming / Statsd

PHP component easing the statsd usage
13 stars 14 forks source link

added timeout to send the information and not get long waiting time #18

Open andrescevp opened 8 years ago

mikaelrandy commented 8 years ago

Why not, but as it is strongly recommended to use StatsD through UDP protocol, i'll ask myself about this PR usage. Technically, all is good, but theoretically, this PR will encourage TCP usage.

Do we really want this ?

ping @omansour

andrescevp commented 8 years ago

I think that yes, because if the server don't answer we have a issue about the connection, my point is avoid useless waiting time, if the server is down we just discart the information (bad luck, call you sys admin =P)

omansour commented 8 years ago

txs for contributing !

ok, but this value should be a parameter somehow. maybe not used a constant but a property with a default value, and add a setter ?

mikaelrandy commented 8 years ago

@andrescevp using UDP, you not wait for server response (fire and forget), and you dont have waiting time.

That's why i ask myself about the consequences of this parameter.

omansour commented 8 years ago

we cant just considering this like a regular timeout for those not using udp. But not in a constant :)