BedrockStreaming / Statsd

PHP component easing the statsd usage
13 stars 14 forks source link

Cannot add sign to a gauge value #25

Closed alexsegura closed 1 year ago

alexsegura commented 6 years ago

It is actually possible to add a +/- to a gauge

Adding a sign to the gauge value will change the value, rather than setting it. https://github.com/etsy/statsd/blob/master/docs/metric_types.md#gauges

But it impossible with the component because:

I can still use the writeDatas method directly but this is not satisfying.

This should definitely be supported by the client, as this is a valid StatsD message. I think this can be implemented quite easily, without any BC breaks.

I can submit a pull request.

Oliboy50 commented 6 years ago

Hello @alexsegura

it seems that you're totally right, thank you for mentioning that.

Your pull request would be really appreciated :)