BedrockTweaks / Files

Other
7 stars 7 forks source link

feat(files): Peace and Quiet with sounds.json #114

Open NSPC911 opened 2 days ago

NSPC911 commented 2 days ago

The heaviest and most massive change I have made, hence highly doubt that it will be merged.

Packs added:
  • Quieter Thunder
  • Quieter Explosions
  • Quieter Consumables
  • Quieter Sculk Sensors
  • Quieter Sculk Shriekers
  • Quieter Allay
  • Quieter Armadilloos
  • Quieter Breezes
  • Quieter Camels
  • Quieter Ender Dragon
  • Quieter Frogs
  • Quieter Iron Golems
  • Quieter Bogged (as part of Quieter Skeletons)
  • Quieter Sniffers
  • Quieter Snow Golems
  • Quieter Tadpoles
  • Quieter Wardens
  • Quieter Wither

Packs tweaked:

Issues resolved:
  • Resolves #25
  • Resolves #26
  • Resolves #27
  • Resolves #28
  • Resolves #29
  • Resolves #64

By checking the following boxes with an X, you ensure that:

(Hadn't had the time to test them, sorry!)

SquatchHunter commented 1 day ago

if you prepare a .mcpack we can test these all work as a whole, I assume it will be a vast list of combinations to add aswell if thats not already done

NSPC911 commented 1 day ago

I assume it will be a vast list of combinations to add aswell if thats not already done

no combinations required as long as the jsons merge properly

if you prepare a .mcpack we can test these all work as a whole

will have to get back home to see (maybe make a small script because im lazy)

NSPC911 commented 1 day ago

https://github.com/BedrockTweaks/Files/pull/114/commits/93b6a7a14bd6506fb9241bdab89a093767d69601 Force Pushes are funny

NSPC911 commented 1 day ago

@SquatchHunter sounds.json

drav0011 commented 11 hours ago

Most seems good but

NSPC911 commented 5 hours ago

Most seems good but

  • Quieter Allays pack_icon does not work, route and or id is wrong
  • Tested a couple of packs and looks fine, but all of them should be tested before making a pr, you made a script which merged all the sounds.json could have used that file
  • sounds.json should just contain the changes, same as JSONUI Example:
    {
    "entity_sounds": {
        "entities": {
            "armadillo": {
                "volume": 0.05
            }
        }
    }
    }
SquatchHunter commented 4 hours ago

Minecraft Bedrock will deep merge the "last loaded" pack over the vanilla files so to minecraft's engine, all the values are there so if you just included the changes, minecraft will handle the rest

as for testing, I wont be able to till later today / tonight

NSPC911 commented 1 hour ago

@drav0011 done