Closed SquatchHunter closed 1 month ago
uhm, actually lets keep english language same in all the instances, as its called "colorful slimes", lets keep the combination folder names to be "color" not "colour"
OMG
Fix the spelling of color, revert your last commit and make the combinations name to be "color" instead of "colour" for real this time
really late review, but need black slime as well, you forgot about it i believe and also there are random
pack_icon.png
files in the combinations for colored_slime
this pr is useless because we will use priority instead of combinations so I don't think this pr will be accepted
As mentioned due to priority this will not be needed, but some notes
adjusted pistonArmSticky.png in colour slimes to reflect vanilla Not sure what was the change here
Also we use here en_US naming for everything to keep in pair with vanilla tweaks and vanilla minecraft ex: behavior_packs
note: the combinations are listed below dirt in the packs.json file to hopefully avoid merge conflicts with #317, feel free to move in a future PR / commit. secondary note: I have only tested black in game, but since the other packs were copy paste, it should be fine... I hope
By checking the following boxes with an X, you ensure that:
[x] The pack was tested ingame in at least one device.
[x] The pack is an existing BT pack, is a missing pack from VT or is an accepted pack/change in a discussion.
[x] The pack code follows the style guide.
[x] The commits follow the contribution guidelines.
[x] The PR follows the contribution guidelines.
[x] (Optional) Tested in Windows
[ ] (Optional) Tested in Android
[ ] (Optional) Tested in iOS
[ ] (Optional) Tested in any console
[ ] (Optional) Tested in BDS