BedrockTweaks / Files

Other
7 stars 7 forks source link

[Aesthetic] All Packs Done #84

Closed NSPC911 closed 1 week ago

NSPC911 commented 1 week ago

Packs Added:

Fixes:

Relevant Issues fixed:

By checking the following boxes with an X, you ensure that:

drav0011 commented 1 week ago
NSPC911 commented 1 week ago
  • Try to keep the commits following the contribution guideline for the following ones
  • I'll try, the main reason why I stick to mine is because I get confused on what to name them
  • Separate the more zombies to it's own pull request, that category will need further work apart from what is done to ensure compatibility, will continue the work from what you have done.
  • More Zombies don't really need any more compatibility AFAIK, not sure what you have planned, but I'll remove it if you want to
  • Good for noticing the key issues
  • Thanks
  • The variation rename is good, but is not a confirmed change, do not make changes like this in the future before opening an issue and discussing it
  • Undo change?
drav0011 commented 1 week ago

The commits should follow the guidelines because of 2 reasons, 1st one being consistency across the repository, 2nd is automation, having them follow the defined guidelines simplifies sorting out and categoricing the changes.

More Zombies don't really need any more compatibility AFAIK, not sure what you have planned No matter how many you select they will have random textures, not just when you choose all of them

Undo change? Leave it there, just note it for the future ones

NSPC911 commented 1 week ago

The commits should follow the guidelines because of 2 reasons, 1st one being consistency across the repository, 2nd is automation, having them follow the defined guidelines simplifies sorting out and categoricing the changes.

Sure, will change

No matter how many you select they will have random textures, not just when you choose all of them

So you want more zombies to variate even when two are selected?

NSPC911 commented 1 week ago

Closed PR. Reason: Switching to separate branches for Aesthetic packs and More Zombies packs