search

BeePong / 42_transcendence

This group project is about creating a website for the mighty Pong contest!🏓
2 stars 4 forks source link

fix 4 player tournament #116

Closed pixelsnow closed 2 months ago

pixelsnow commented 2 months ago

@linhtng @liocle @wengcychan @djames9 Hopefully a fix. Everyone, please test this well from your computers, I don't trust my build because I couldn't reproduce the solo game issue yesterday. God bless

liocle commented 2 months ago

We have tested solo games, 2, 4 players tournaments, and everything was looking to work flawlessly locally and remotely.

@linhtng I have also tested issue #93 and authentication occurs properly, the redirection for some reason point again to https://localhost:8443/tournament/?login=success instead of the remote site, but pressing back brings back to the proper remote server: i.e. https://172.50.70.153:8443/tournament/ and all functions fine from that moment. Only a minor glitch remains but probably fine for eval

wengcychan commented 2 months ago

@liocle @linhtng I don't know if the query string ?login=success affects it. I added it in the PR for synchronizing the login state between two tabs.