BeePong / 42_transcendence

This group project is about creating a website for the mighty Pong contest!🏓
2 stars 4 forks source link

Bug/User Management: Implementing Remote Authentication (1.0) #93

Open liocle opened 2 months ago

liocle commented 2 months ago

Context:

Issue:

42 site is reached, but the authentication is "redirected" to the user's local host instead of the remote server onto which it should login leading to a ERR_CONNECTION_REFUSED as it attempts to connect to a local game server instead of the remote : https://localhost:8443/oauth/accounts/oauth_token/?code=blaexamplebla&state=qwerty%7Chttps%253A%2F%2Flocalhost%253A8443

Note:

If when debugging the server is also running locally, the authentication is successful but logs in locally instead of remotely

linhtng commented 2 months ago

I registered the url on 42 intra now. Please change FTAPI_REDIR_URL in your .env file to https://172.50.70.153:8443/oauth/accounts/oauth_token/ and try again.

liocle commented 2 months ago

Maybe you could update the .env file, pin it to our discord as we used to do and inform everyone of the change.

liocle commented 2 months ago

Tests we made in PR review https://github.com/BeePong/42_transcendence/pull/116#event-14193287625 with the proposed modified FTAPI_REDIR_URL.

Authentication occurs properly, the redirection for some reason point again to https://localhost:8443/tournament/?login=success instead of the remote site, but pressing back brings back to the proper remote server: i.e. https://172.50.70.153:8443/tournament/ and all functions fine from that moment. Only this minor glitch remains but probably fine for eval.

@pixelsnow @linhtng @wengcychan @djames9 Please note that the env file should be updated in the field: FTAPI_REDIR_URL with the ip address of the server if one want to remotely authenticate to the game server using 42 auth.