[Bug]: Clockwork Cult ruleset fails to execute, leading to clockies being unable to interact with the round.

BYOND Version

514.1589

Round Date

2023/10/22

Round ID

46332

Test merges

I wasn't in the round. Supposedly these (taken from following round):

https://www.github.com/beestation/beestation-hornet/pull/9124 https://www.github.com/beestation/beestation-hornet/pull/9337 https://www.github.com/beestation/beestation-hornet/pull/10059 https://www.github.com/beestation/beestation-hornet/pull/10073

Describe the bug

Clockwork Cult ruleset failed to execute, causing the game to refund the threat budget, but it still loaded Rebee and the players chosen by the ruleset in it, the players had seemingly non-functional antag datums and couldn't interact with the machinery, preventing them from interacting with the round.

Admins salvaged the round by deleting these players, kicking them back to the lobby and then respawning them with the datum given manually through the traitor panel. Ping tamus or not_a_shark on discord for more info on that.

What did you expect?

Clockies spawning normally and being able to play.

Reproducible steps

Try to execute the ruleset and see what happen I suppose. If that doesn't work, the round mentionned had some runtimes related to the job subsystem failing to get "Servant of Ratvar" as a valid job, followed by other runtimes related to clockies.

Someone probably disconnected during a minor sleep causing the runtime.

[2023-10-22 19:05:39.141] runtime error: Cannot execute null.log talk().
 - proc name: hierophant message (/proc/hierophant_message)
 -   source file: code/game/gamemodes/clock_cult/clockcult.dm,267
 -   usr: (src)
 -   src: null
 -   call stack:
 - hierophant message("<b></b> has been successfully ...", null, "<span class=\'sevtug\'>", 0, 1)
 - add servant of ratvar( (/mob/living/carbon/human), 1, 0, /datum/antagonist/servant_of_r... (/datum/antagonist/servant_of_ratvar), Servants Of Ratvar (/datum/team/clock_cult))
 - Clockwork Cult (/datum/dynamic_ruleset/roundstart/clockcult): execute(0)
 - dynamic mode (/datum/game_mode/dynamic): execute roundstart rule(Clockwork Cult (/datum/dynamic_ruleset/roundstart/clockcult))
 - /datum/callback (/datum/callback): InvokeAsync()
 - Timer (/datum/controller/subsystem/timer): fire(0)
 - Timer (/datum/controller/subsystem/timer): ignite(0)
 - Master (/datum/controller/master): RunQueue()
 - Master (/datum/controller/master): Loop()
 - Master (/datum/controller/master): StartProcessing(0)
 - 
[2023-10-22 19:05:39.297] runtime error: Cannot execute null.forceMove().
 - proc name: execute (/datum/dynamic_ruleset/roundstart/clockcult/execute)
 -   source file: code/game/gamemodes/dynamic/dynamic_rulesets_roundstart.dm,611
 -   usr: null
 -   src: Clockwork Cult (/datum/dynamic_ruleset/roundstart/clockcult)
 -   call stack:
 - Clockwork Cult (/datum/dynamic_ruleset/roundstart/clockcult): execute(0)
 - dynamic mode (/datum/game_mode/dynamic): execute roundstart rule(Clockwork Cult (/datum/dynamic_ruleset/roundstart/clockcult))
 - /datum/callback (/datum/callback): InvokeAsync()
 - 
[2023-10-22 19:05:39.298] runtime error: The starting rule "Clockwork Cult" failed to execute.
 - proc name: execute roundstart rule (/datum/game_mode/dynamic/proc/execute_roundstart_rule)
 -   source file: code/game/gamemodes/dynamic/dynamic.dm,629
 -   usr: null
 -   src: dynamic mode (/datum/game_mode/dynamic)
 -   call stack:
 - dynamic mode (/datum/game_mode/dynamic): execute roundstart rule(Clockwork Cult (/datum/dynamic_ruleset/roundstart/clockcult))
 - /datum/callback (/datum/callback): InvokeAsync()

[2023-10-22 19:04:31.611] GAME: DYNAMIC: Dynamic mode parameters for the round:
[2023-10-22 19:04:31.611] GAME: DYNAMIC: Centre is 0, Width is 1.8, Forced extended is Disabled, No stacking is Enabled.
[2023-10-22 19:04:31.611] GAME: DYNAMIC: Stacking limit is 90.
[2023-10-22 19:04:31.611] GAME: DYNAMIC: Dynamic Mode initialized with a Threat Level of... 54.1! (51.9 round start budget)
[2023-10-22 19:04:31.613] GAME: DYNAMIC: Listing 15 round start rulesets, and 25 players ready.
[2023-10-22 19:04:31.617] GAME: DYNAMIC: weight of Blood Cult adjusted from 3 to 1.65 by repeated_mode_adjust
[2023-10-22 19:04:31.618] GAME: DYNAMIC: FAIL: Clown Ops failed acceptable: threat_level (54.1) < requirement (101)
[2023-10-22 19:04:31.618] GAME: DYNAMIC: FAIL: Revolution failed acceptable: minimum_players (35) > population (34)
[2023-10-22 19:04:31.618] GAME: DYNAMIC: FAIL: Extended failed acceptable: threat_level (54.1) < requirement (101)
[2023-10-22 19:04:31.618] GAME: DYNAMIC: FAIL: Devil failed acceptable: threat_level (54.1) < requirement (101)
[2023-10-22 19:04:31.618] GAME: DYNAMIC: FAIL: Meteor failed acceptable: threat_level (54.1) < requirement (101)
[2023-10-22 19:04:31.619] GAME: DYNAMIC: No more rules can be applied, stopping with 51.9 left.
[2023-10-22 19:04:31.620] GAME: DYNAMIC: Picked a ruleset: Clockwork Cult, scaled 0 times
[2023-10-22 19:04:46.491] ACCESS: Logout: (CKEY WHO WILL NOT BE NAMED)
[2023-10-22 19:05:18.614] GAME: Z-level Reebe loaded at 0,0,10
[2023-10-22 19:05:18.616] GAME: DYNAMIC: 16.9 round start budget was left, donating it to midrounds.
[2023-10-22 19:05:18.617] GAME: DYNAMIC: Picked the following roundstart rules: Clockwork Cult, 
[2023-10-22 19:05:39.298] GAME: DYNAMIC: Roundstart Clockwork Cult is cleaning up, failed to execute.

BeeStation / BeeStation-Hornet