BeeStation / BeeStation-Hornet

99.95% station. 0.05% bees
https://beestation13.com
GNU Affero General Public License v3.0
200 stars 670 forks source link

[Bug]: Mobs have mismatched shadows #10693

Open Fronsis opened 5 months ago

Fronsis commented 5 months ago

BYOND Version

No response

Round Date

No response

Round ID

No response

Test merges

No response

Describe the bug

Screenshot_12 Screenshot_13

As you can see, mobs for some reason appear to overlap their sprites, showing both their dead and alive sprite when exposed to darknes, when you approach to them they appear normal

I've also noticed this bug sometimes when observing, when some explo ruins load a little buggy and have scuffed lights and i believe i experienced a similar one when i was a spider alongside Security/AI cameras also displaying this weird behaviour

We had some discussion with Dakae about what might be causing it https://discord.com/channels/427337870844362753/943311132007997490/1213709588566773780

What did you expect?

I expected to see the mobs on their correct sprite (in the case of the screenshots i, as a xenomorph, i should've been able to see them dead with my thermal vision

Reproducible steps

1- Spawn a carp alive on space 2- Spawn as a xenomorph on a dark area 3- Kill the carp outside of the view of the xeno( move the xeno to somewhere else and kill the carp) 4- The carp should appear like the screenshot

Alternative this might also work with a human and thermal vision and with Security cameras/AI eye

HowToLoLu commented 5 months ago

It doesn't occur at all with humans, just xenomorphs and perhaps some other player controllable mobs have this issue, and it isn't an exploration zlevel issue.

Additionally direction of the shadow is affected by the atom's direction, looking in the direction it's been pulled or moved. Most notably the shadow actually animates.

Human with thermal vision goggles:

image

Xenomorph with low night vision set (SEE_MOBS part of their sight by default): image

Same carp, but Buildmode thrown upward: image

Fronsis commented 5 months ago

Interesting.. i think Spiders could have it too

Have you tested with cameras/ai eye? I think if the area was dark it showed the xeno issue

HowToLoLu commented 5 months ago

It just got even wierder- it happens for AI as well. but the way I got it to work is what makes it wierd.

I started placing engine floors, which didn't cancel the star lighting, so I manually started placing an area of the type /area/maintenance image

Which then resulted in this being visible to ghosts too as well as the AI

image

Maybe humans are the only thing with working mob shadows?

Fronsis commented 5 months ago

It just got even wierder- it happens for AI as well. but the way I got it to work is what makes it wierd.

I started placing engine floors, which didn't cancel the star lighting, so I manually started placing an area of the type /area/maintenance image

Which then resulted in this being visible to ghosts too as well as the AI

image

Maybe humans are the only thing with working mob shadows?

That might explain why i recall seeing it on explo, perhaps i was observing an explorer and i remember the map loaded strangely and buggy so the lightning was odd all over the place and spider mob that were dead were buggy like that

PowerfulBacon commented 5 months ago

I believe this is a byond issue with the way certain items interact with darkness tiles. You will notice if you have an item in your inventory, then when that inventory tile is above a darkness tile, it will render its original icon rather than the current icon. I have no idea why this happens. Edit: actually if it works for ghosts too, then it can't be the byond darkness issue. Could be an issue with the vis overlays thing.

Fronsis commented 5 months ago

I believe this is a byond issue with the way certain items interact with darkness tiles. You will notice if you have an item in your inventory, then when that inventory tile is above a darkness tile, it will render its original icon rather than the current icon. I have no idea why this happens. Edit: actually if it works for ghosts too, then it can't be the byond darkness issue.

I believe i've seen it as ghost.. can't be 100% sure though since it might'vehappened under very specific circumstances

But yeah HowToLuLu explained me it could be caused by BYOND but they still tested some stuff that showed otherwise

github-actions[bot] commented 4 months ago

This issue has been inactive for long enough to be automatically marked as stale. If this was a bug report and hasn't been addressed yet, and is still a problem, please don't hesitate to notify a maintainer.