We have a lot of places in the code still expecting food args to be passed through reagent_containers and not the edible component.
This is important, because it will be the nail in the coffin to any future bugs that may crop up, as reagent_containers/food isnt even a viable typepath anymore
Testing Photographs and Procedure
Screenshots&Videos
Drinking glasses properly update name, appearance, and desc when filling/emptying of drink reagents
https://github.com/user-attachments/assets/f9d1e830-0491-45ed-9c98-ae4cdfeacdfb
Splashing someone applies the reagent, if possible. In this case, welding fuel
Drinking moodlets apply as normal
Changelog
:cl: rkz, Ryll/Shaps, LemonInTheDark, Couls, JohnFulpWillard, OnlineGirlfriend
refactor: repaths drinks and reagent containers to a centralized file. Food reagent_containers no longer exist.
fix: fixed a few outlying food checks that still expected reagent_containers
fix: fixed caltrop bug with plates
fix: hot chocolate no longer spontaneously becomes chocolate milk when put in a different container
code: moves hot chocolate, tea, coffee "food" recipes to drink recipes
tweak: hot chocolate now inherits milk's healing (its made from milk, get it?)
tweak: caltrop now applies to broken bottles
tweak: drinking from used glasses can now pass diseases, same as food. Bartenders! Clean your glasses!
tweak: adds soda shaking. Shaking/throwing a soda around before opening may make it erupt when opened.
rscadd: soda shaking noises
/:cl:
About The Pull Request
This is the pr that removes all remaining reagent_container food references and kills /item/reagent_container/food & its subtypes.
Additionally, a minor refactor of drink splashing attack chain.
Ports:
Why It's Good For The Game
We have a lot of places in the code still expecting food args to be passed through reagent_containers and not the edible component.
This is important, because it will be the nail in the coffin to any future bugs that may crop up, as
reagent_containers/foodisnt even a viable typepath anymoreTesting Photographs and Procedure
Screenshots&Videos
Drinking glasses properly update name, appearance, and desc when filling/emptying of drink reagents https://github.com/user-attachments/assets/f9d1e830-0491-45ed-9c98-ae4cdfeacdfb Splashing someone applies the reagent, if possible. In this case, welding fuel  Drinking moodlets apply as normal Changelog
:cl: rkz, Ryll/Shaps, LemonInTheDark, Couls, JohnFulpWillard, OnlineGirlfriend refactor: repaths drinks and reagent containers to a centralized file. Food reagent_containers no longer exist. fix: fixed a few outlying food checks that still expected reagent_containers fix: fixed caltrop bug with plates fix: hot chocolate no longer spontaneously becomes chocolate milk when put in a different container code: moves hot chocolate, tea, coffee "food" recipes to drink recipes tweak: hot chocolate now inherits milk's healing (its made from milk, get it?) tweak: caltrop now applies to broken bottles tweak: drinking from used glasses can now pass diseases, same as food. Bartenders! Clean your glasses! tweak: adds soda shaking. Shaking/throwing a soda around before opening may make it erupt when opened. rscadd: soda shaking noises /:cl: