BeeStation / BeeStation-Hornet

99.95% station. 0.05% bees
https://beestation13.com
GNU Affero General Public License v3.0
200 stars 683 forks source link

Adds New Barsign #11704

Closed Raven-Industries closed 1 week ago

Raven-Industries commented 1 month ago

About The Pull Request

This PR adds a single new bar sign option: "The Blue Note".

Why It's Good For The Game

While current bar signs offer a wide range of tonal variety to choose from, none of them quite fit the theme of numb despair, despite regular opportunities for such an emotion within the average SS13 round. This hopefully fills that hole.

Disclosure: the name is a reference. https://github.com/user-attachments/assets/e8a5d2c7-f45c-461e-8e9e-b07b2e860823

Testing Photographs and Procedure

Screenshots&Videos ![evidence](https://github.com/user-attachments/assets/2b626e3c-d168-4b57-91d1-cc329cdfea58) ![bluenote](https://github.com/user-attachments/assets/c87793eb-0d57-4433-ae61-7ded85840095)

Changelog

:cl: imageadd: added new bar signage /:cl:

Tsar-Salat commented 1 month ago

This looks like it will be really hard to read with any level of bloom enabled

MarkusLarsson421 commented 1 month ago

Blue Oyster bar, when?

ClownMoff commented 1 month ago

Yeah the sprite is hard to read

Raven-Industries commented 1 month ago

This looks like it will be really hard to read with any level of bloom enabled

Here's what it looks like with in-game bloom set to 0% and 100%, respectively: image

Yeah the sprite is hard to read

As far as readability concerns, is it something like color or font size that seems to be the issue, or something else?

MarkusLarsson421 commented 1 month ago

Colour I'd say, it is dark blue on black. They sort of blur together a tad too much.

Raven-Industries commented 1 month ago

I lightened the blue and the background, yea or nay?

Images ![image](https://github.com/user-attachments/assets/c7b9a918-c976-4771-87f4-283bde896358) ![bluenote2](https://github.com/user-attachments/assets/5ece94e6-afd7-4417-a106-bc5136eadbbe)
Raven-Industries commented 1 month ago

Updated the colors to a higher-contrast version. Name is still the same because I couldn't think of anything to give it a space twist (open to suggestions if that's a non-negotiable). bluenote3

ClownMoff commented 1 month ago

Updated the colors to a higher-contrast version. Name is still the same because I couldn't think of anything to give it a space twist (open to suggestions if that's a non-negotiable). bluenote3 bluenote3

I would make it slightly faster I think the animation is too slow and not so fluid

Raven-Industries commented 1 month ago

Like so? I cut the times in half for the initial on-sequence. Timing ratio between frames is still the same though because it's meant to match the lengths of the respective notes. bluenote4

ClownMoff commented 1 month ago

That one looks good