search

BeeStation / BeeStation-Hornet

99.95% station. 0.05% bees
https://beestation13.com
GNU Affero General Public License v3.0
200 stars 682 forks source link

Fixes cybernetic hearts turning into regular hearts #11774

Closed RDS88-beeman closed 3 weeks ago

RDS88-beeman commented 3 weeks ago

About The Pull Request

Cybernetic hearts would formerly (permenantly) swap icon states into normal, ordinary person hearts whenever they stopped beating. This mostly affected IPCs, as they start with cybernetic hearts by default. This fixes that bug. Now cybernetic hearts will properly show up like cybernetic hearts, even when the person they're in is reduced to a fine paste.

This entire feature could use a refactor but I am NOT the man for the job.

Why It's Good For The Game

Bug bad. This is a bug that annoyed me and only me, but bug bad.

Testing Photographs and Procedure

Screenshots&Videos in this video you can see me gib an IPC, and watch their heart stop beating. On the current server, this would cause their heart to take on a normal appearance. As you can see, it no longer does. https://github.com/user-attachments/assets/88e8ef30-dfd9-4f4f-a92f-d0703f803e97

Changelog

:cl: fix: IPCs no longer contain fleshy human hearts in disguise. /:cl:

RDS88-beeman commented 3 weeks ago

wait shit this doesn't work give me a minute

PowerfulBacon commented 3 weeks ago

Describe the testing process and include screenshots/videos.

Rukofamicom commented 3 weeks ago

You can open the View Variables screen with a right click on yourself, and then in the drop down box in the upper right there is a Manipulate Organs option. Use this to drop your heart on the ground and it will beat for a while until it stops and you can record that.

RDS88-beeman commented 3 weeks ago

testing evidence added