BeeStation / BeeStation-Hornet

99.95% station. 0.05% bees
https://beestation13.com
GNU Affero General Public License v3.0
200 stars 682 forks source link

TRAIT_STUNRESISTANCE does nothing. #11828

Open PowerfulBacon opened 2 weeks ago

PowerfulBacon commented 2 weeks ago

Rust regen and pumpup from the syndicate item uses TRAIT_STUNRESISTANCE which doesn't do anything.

Tsar-Salat commented 1 week ago

Appears to have been added here in

Seems to be traceable to a TG pr, which added a reorganizing of how batoning works. A trait check occurs on baton attack end.

Cenrus just ported the definition, he literally wrote it no where else. The pr linked wasnt ported, he just included the new trait for some reason?

Then a few years later, Lamiales added TG's heretic system, including adding traits that hook into this "new" stun system. A system we do not have.

So yea.

PowerfulBacon commented 1 week ago

I am currently in the process of refactoring traits to add value traits, stun resistance will be merged with these so that the trait applies modifiers rather than full or no resistance