BeeStation / BeeStation-Hornet

99.95% station. 0.05% bees
https://beestation13.com
GNU Affero General Public License v3.0
200 stars 682 forks source link

Syndicate Survey Shuttle - Alternative lavaland spawn #11846

Open Marshmellow105 opened 2 weeks ago

Marshmellow105 commented 2 weeks ago

About The Pull Request

Adds my own rendition of the Syndicate base, this time turned into a ship (Nonfunctional). It has almost all the features of the old base, plus some additions, and will spawn as a variant of the existing Syndicate base.

What I took out:

Why It's Good For The Game

Fresh coat of paint on an otherwise generally old lavaland structure.

Testing Photographs and Procedure

Screenshots&Videos ![syn-chem](https://github.com/user-attachments/assets/127e3f91-13e4-4d52-aee7-22dedccbc5b3) ![syn-coms](https://github.com/user-attachments/assets/1d8dcf86-5622-4384-b123-633422e9a0a0) ![syn-dock](https://github.com/user-attachments/assets/2b624fc2-0232-4bf2-89ed-e9ff8a7239f2) ![syn-engi](https://github.com/user-attachments/assets/c269027e-5704-4530-9235-3b9032f69f6e) ![syn-genetic](https://github.com/user-attachments/assets/201fa04c-4e70-4937-bb6a-ad512a17c280) ![syn-med](https://github.com/user-attachments/assets/4f30aed2-d698-4465-9cab-39e13666af4e) ![syn-bar](https://github.com/user-attachments/assets/5f649ea5-8b81-4acb-be86-ad99a7bad3e3) ![syn-bridge](https://github.com/user-attachments/assets/295d474d-5226-4195-9953-ce1d3b2aa4f1) ![syn-brig](https://github.com/user-attachments/assets/c7953c59-69fa-4f28-b9e3-646b13cff169) ![syn-cargo](https://github.com/user-attachments/assets/24a26ca4-431b-4a9a-9d6a-44bcaf976d0d)

Changelog

:cl: marshmellow10, MarkusLarsson421, Therealdoooc213, Tsar-Salat add: adds the Syndicate Survey Shuttle as a lavaland ruin code: Makes it a 50/50 between getting this or the old base (I think) /:cl:

Tsar-Salat commented 2 weeks ago

Can we have a (admin only) functioning syndie dock?

Sometimes I wanna do cool shuttle stuff and send shuttles to the syndicate base but it doesn't let me

Fronsis commented 2 weeks ago

Can we have a (admin only) functioning syndie dock?

Sometimes I wanna do cool shuttle stuff and send shuttles to the syndicate base but it doesn't let me

That would be amazing. specially since the lavaland base has a cargo dock and i remember asking for supplies a few times and seeing a ship dock is x10 better than random pod for immersion

MarkusLarsson421 commented 2 weeks ago

Can we have a (admin only) functioning syndie dock?

Sometimes I wanna do cool shuttle stuff and send shuttles to the syndicate base but it doesn't let me

I'm looking into making something simple for this. I'll probably follow it up with a separate PR.

Marshmellow105 commented 2 weeks ago

Can we have a (admin only) functioning syndie dock?

I spoke to Markus about this and it might be possible to do this if I create a new syndicate cargo shuttle that only we can spawn and have that able to dock here. That would be fairly easy to do provided docking next to the holofield is okay.

I'll look into that once I figure out why the mapdiff thing is freaking out.

Marshmellow105 commented 2 weeks ago

I took out the rocket launcher and hardsuit to cut any doubts about balance

please remove the balance tag!

MarkusLarsson421 commented 2 weeks ago
Mapping Review These drawers should be replaced with the security and medical records variants. ![image](https://github.com/user-attachments/assets/f0e01dce-8d82-4c06-825a-051822b2f269) The fax machine should probably start of hacked so they can contact the Syndicate Command? ![image](https://github.com/user-attachments/assets/f31ae327-b0c7-46be-b79f-e3daae4592be) All the explosive walls (marked with diamonds shouldn't be hittable from the outside. ![image](https://github.com/user-attachments/assets/c240d79d-6967-4a36-8ad8-c95f725140cd) Air pipe leading no where. ![image](https://github.com/user-attachments/assets/44110632-fb85-4b55-a412-f7cc0bd8d01d) Plating. ![image](https://github.com/user-attachments/assets/8dd12b78-af16-4449-8dde-d4c3865330e9) Leftover Virology storage. ![image](https://github.com/user-attachments/assets/3d207834-cb6e-4b4f-a347-db52d7e8e437) And biohazard poster? Which is also blocking the shower icon. ![image](https://github.com/user-attachments/assets/f704c31b-fb22-4bd2-988d-6dcf33ae16ff) Avoid wall pipes. Corg toxins has a good example on how to handle this sort of thing. ![image](https://github.com/user-attachments/assets/a2f25b5e-fdbf-4300-b9e3-0d86ae78cbab) No button to unbolt the door and a tad dark. ![image](https://github.com/user-attachments/assets/6e43e5d0-ce5d-4079-ab33-c1ae921402d1) A tad dark here too, I think the long wide lights are stronger. Mix and match them a bit. ![image](https://github.com/user-attachments/assets/cdccc5ea-474b-47bc-8e13-4e9660738f9b) This has A LOT of energy. Use the Engineering subtype or use one without the var edit. ![image](https://github.com/user-attachments/assets/a7ed91d7-c172-4c5c-b45a-53bf6261fa5e) Maybe replace with a prisoner closet? Make sure they got access to it, give the prisoner actual prisoner clothes. ![image](https://github.com/user-attachments/assets/765d2a92-4b8e-41ae-a1f0-ac9bd907b37e) No access to the genetics console. ![image](https://github.com/user-attachments/assets/38507b79-a223-4270-97c4-c134e462abc5) No access to Medical Records Console. Should they even have access to it? Same issue with the Security Records console. ![image](https://github.com/user-attachments/assets/998c6f74-556d-47ea-b556-66427a0e1de6) It might not require extra lights but could be considered. ![image](https://github.com/user-attachments/assets/7a923eb9-649e-49ed-94aa-85b210cbe0cb) Add some blood here to make it look used. Perhaps a body bag nearby too. ![image](https://github.com/user-attachments/assets/8303cfbd-dc87-476c-835b-8302609091af) Missing the actual intercoms and the paper of all the radio frequencies. ![image](https://github.com/user-attachments/assets/ed45aa08-9cfe-49bd-9fbb-bc9eec3a6efb) This should not be a chameleon rubber stamp. Use the regular denied stamp. ![image](https://github.com/user-attachments/assets/b2e7fab8-41c4-4230-a699-354941996e0a) Holofield stays on after being blown up, consider using the non-roundstart variant so it'll actually use power. This may risk it being depowered if no one arrives to boot up the turbine. Could consider not fixing the SMES if so. ![image](https://github.com/user-attachments/assets/0a5e31ab-149d-4c3d-8c02-dd10ba9b1d9b) Lacking a power monitor, it might've been that you removed it for the shuttle console I asked you to add? ![image](https://github.com/user-attachments/assets/7f35ddc5-8cba-45dd-bac1-290bf4d72374) Great work and a great design! I love it.
MarkusLarsson421 commented 2 weeks ago

If you do change the holofield where it might risk going down, do note there is no way to easily refill it with air, consider adding a vent and scrubber there.

Marshmellow105 commented 2 weeks ago

These drawers should be replaced with the security and medical records variants.

This was already the case!! You probably didn't see any records because you were on a local all alone x)

The fax machine should probably start of hacked so they can contact the Syndicate Command?

I changed around some variables to hopefully hide this machine from the list and allow it to fax the syndicate. Specifically 'allow_exotic_faxes' and 'syndicate_network'

All the explosive walls (marked with diamonds shouldn't be hittable from the outside.

Done!

Air pipe leading no where.

Fixed the smartpipes there.

Leftover Virology storage and biohazard poster? Which is also blocking the shower icon.

Oopsie, fixed now.

Avoid wall pipes. Corg toxins has a good example on how to handle this sort of thing.

Relic of the old base, should be better now. atmo

Dark areas

Fixed with more lights and a window in med.

Holofield stays on after being blown up, consider using the non-roundstart variant so it'll actually use power. This may risk it being depowered if no one arrives to boot up the turbine. Could consider not fixing the SMES if so.

Changed this to just the 'strong' variant and left the syndicate smes

Maybe replace with a prisoner closet? Make sure they got access to it, give the prisoner actual prisoner clothes.

Good idea!

No access to...

I'll fix the DNA consoles, and I think I'll swap out the bridge consoles. Despite being syndicate consoles I'm not sure they're fit for this base. Wouldn't want agents setting everyone to arrest every round.

Missing the actual intercoms and the paper of all the radio frequencies.

Intercomms are behind you, and I just added the second paper.

This should not be a chameleon rubber stamp.

This is intentional and I would like to keep this as is. It allows for the new fax machine to be used to get sneaky with the station and misdirect them! Maybe they could send faxes to the bridge with a CC stamp saying 'its free AA day' and if the captain doesn't check where it came from it could lead to some silly stuff!

MarkusLarsson421 commented 2 weeks ago

This was already the case!! You probably didn't see any records because you were on a local all alone x)

Oh... right. xd

Changed this to just the 'strong' variant and left the syndicate smes

Strong variant only increases the rangw of it if I am not mistaken, but it works.

It allows for the new fax machine to be used to get sneaky with the station and misdirect them!

Fair, I like that.

MarkusLarsson421 commented 2 weeks ago

Intercomms are behind you, and I just added the second paper.

Should maybe be on the tables? Looks more like a standard intercom rather than a tool. But its up to personal preference really.

Marshmellow105 commented 2 weeks ago

image okay I didnt fix it

MarkusLarsson421 commented 2 weeks ago
Mapping Review PT.2 The air / scrubber both connect to the layer adapter. ![image](https://github.com/user-attachments/assets/efff377e-1e68-4717-bfd4-ad5934881add) Decal covering the center par of the grate, looks a bit off. ![image](https://github.com/user-attachments/assets/52ac9500-8280-4384-9b7d-ad9839798ce2) You could maybe move the mixers and such for the air supply to layer 2 to skip the layer adapter entirely, but it's a minor thing and doesn't matter. ![image](https://github.com/user-attachments/assets/4d041d1d-e120-4c4c-abce-acb5a24d1a91) Maybe move this a tad inward to give it even more of a unique shape? Minor ideas guy comment. ![image](https://github.com/user-attachments/assets/b48543bb-9e87-4765-a365-a352346ade34) Virology door. ![image](https://github.com/user-attachments/assets/ec00c0b7-8271-48fc-948d-e890d76e99f8) Genetics console still require genetics access. Should probably be removed in a separate PR because console access requirement (except specialized consoles requiring an actual login) are not intuitive or interesting. ![image](https://github.com/user-attachments/assets/4f2082ba-d871-4196-b493-96b7a06144f4) And it still doesn't work. smh :P ![image](https://github.com/user-attachments/assets/ae52db46-0c39-4cf2-b5f5-8c3d7a50c484)
Marshmellow105 commented 2 weeks ago

for some reason there is a 30% chance that if you place this with place-map-template plasma spawns on every tile even though all the scrubbers and vents arent loaded and on and it instantly explodes.

I dont know why and nothing I have done fixes it.

Is this a problem with the current base too??

also I fixed the DNA console access

image

Rukofamicom commented 1 week ago

for some reason there is a 30% chance that if you place this with place-map-template plasma spawns on every tile even though all the scrubbers and vents arent loaded and on and it instantly explodes.

Don't worry this isn't your doing

Marshmellow105 commented 3 days ago

approve my WORKFLOOOOOOOOOOOOOOOOOOOOOOOW