BeeStation / BeeStation-Hornet

99.95% station. 0.05% bees
https://beestation13.com
GNU Affero General Public License v3.0
200 stars 682 forks source link

Fixes the admin actor being reported as null if they changed mob during a sleeping admin action #11860

Closed PowerfulBacon closed 1 week ago

PowerfulBacon commented 1 week ago

About The Pull Request

Admin actions will now log their action based on the owner of the admin datum, rather than the client attached to the usr. This means that if the admin action changes the mob's client then it will not report null.

image

This is safe because the usr.client must always be src.owner.

This issue affects all admin actions that sleep.

Why It's Good For The Game

This will prevent incorrect reports of null performing an admin action for actions that mutate the state of usr.client.

Testing Photographs and Procedure

image

image

Changelog

:cl: fix: Fixes some admin actions erronously showing a null user. /:cl: