BeeStation / BeeStation-Hornet

99.95% station. 0.05% bees
https://beestation13.com
GNU Affero General Public License v3.0
200 stars 682 forks source link

Adds a new variable for force-calling the shuttle #11865

Open Rukofamicom opened 1 week ago

Rukofamicom commented 1 week ago

About The Pull Request

This adds a new variable to the autotransfer system, actually intended for enforcing an upper limit to round length instead of using the decay as an incidental upper limit.

When this variable triggers a shuttle call, it uses the pre-defined "auto evacuation" time of 25 minutes, which is longer than even a green alert call. Players of all kinds doing almost anything will receive ample warning that the round is beginning to wind down when this system is triggered.

Currently this system is set to fire at 1:40, causing rounds to end by 2:05

Why It's Good For The Game

Something something staff meeting + something something player poll.

I'm not 100% on board with this being a good idea (I'm also not against it). The results of the poll are still coming in, as well as the results of the recent dynamic change, but we are getting the vibe that rounds are still taking far too long to end on average, especially when antagonists are too quiet or already removed. The station has no incentive to evacuate when there are no threats, and players are clearly still not inclined to vote for round ends unless the station is absolutely falling apart.

This offers another solution, capping rounds at the length that was originally requested of me when I tackled the autotransfer system, by providing an upper limit of just over two hours long for a round.

Testing Photographs and Procedure

I have fixed the missing space after the period, but I didn't feel like retesting with a whitespace being the only change

image

Changelog

:cl: add: Adds a setting specifically for forcing rounds to end with a shuttle call config: Rounds are configured to call a 25 minute shuttle at 1:40 /:cl:

Rukofamicom commented 1 week ago

This might be unceremoniously closed as more information is gathered, but I wanted to get it out of the way while I have some time to do it since I've started my new job and my spare time is a bit chaotic for the moment.

MarkusLarsson421 commented 1 week ago

I'm obviously not for this, not much else to add.

Fronsis commented 1 week ago

I'd say 2:05hs as the forced max timer seems a little low.. The fact that the crew gets warned and you get 25 minutes of shuttle just makes everyone ''wrap it up'' since it's basically ''Shift it's coming to an end, nothing to do folks'' I would be fine with 2hs 30 minutes as the forced max timer, if by that point no antag or midround hasn't acted then yeah it's either a lowpop shift or people aren't just voting.

Also something tells me that the tip of ''Don't forget to vote to leave'' should specify in which tab the button ''Vote to leave is'' or make it more... visible.

And i hope this contemplates not spawning antags in under that evacuation timer because it will most certainly end up in ''rushed objectives'' or ''unga unga no rp'' since there's extreme time pressure or some midrounds going bananas(which i've seen with pre recent rework dynameme where it spawned dragons right as we were leaving and they conga'd lined into the shuttle to try to kill everybody

PowerfulBacon commented 1 week ago

Setting the standard vote system to 2 hours seems like a much better solution overall

Rukofamicom commented 1 week ago

Setting the standard vote system to 2 hours seems like a much better solution overall

Do you mean setting it so the required votes hits 0 by two hours?

This will likely result in round lengths of 1.5 hours, counting evac time

Fronsis commented 1 week ago

That's usually when the action is at it's peak, even at 2hs there are still rounds where the crew is still fighting X or Y