search

BeeStation / BeeStation-Hornet

99.95% station. 0.05% bees
https://beestation13.com
GNU Affero General Public License v3.0
200 stars 682 forks source link

Subtle messages balloon alert #11870

Open Therealdoooc213 opened 1 week ago

Therealdoooc213 commented 1 week ago

About The Pull Request

Subtle messages (AND HEADSET MESSAGES) appear with a balloon alert saying "You hear a voice in your head.." now

Why It's Good For The Game

Subtle messages are very hard to miss, people aren't always looking at the bottom right of their screen, the balloon alert will get people to look at the bottom of their screen then see the real message.

Testing Photographs and Procedure

Screenshots&Videos Put screenshots and videos here with an empty line between the screenshots and the `
` tags. https://github.com/user-attachments/assets/88a47427-a51c-4904-b372-09af9d4f57df https://github.com/user-attachments/assets/e2b45bf2-7279-4341-bd44-70faa4051f64

Changelog

:cl: tweak: Subtle messages, telepathy, and headset messages now show a balloon alert /:cl:

Marshmellow105 commented 1 week ago

great change, could you add this functionality to headset messages? you send them through the player panel.

Therealdoooc213 commented 1 week ago

This also needs to apply to telekinetic messages, and why not show the message? If you are showing it in balloon chat people are going to be confused when they see "you see a voice in your head" and there's no actual message other than hidden away in the chat where you are diverting their attention away from

Its supposed to be a indicator to divert your attention to the chat. Most people will get the hint of the balloon alert and go to check the chat box imo. I thought telekinesis already did that but i'll add it now.

TsunamiAnt commented 1 week ago

why not show the message?

At least for admin stuff, this way is much better because we usually use spans in those anyways.

PowerfulBacon commented 1 week ago

The only reason is to actually make people look at them anyway. You wouldn't need the ratvar span if the message appeared directly to the user

Therealdoooc213 commented 1 week ago

Also, you cant look back on balloon alerts. Maybe an admin sent you the nuke codes for example but you dont remember them because it appeared in a balloon alert.

TsunamiAnt commented 1 week ago

Good point actually. If we want custom themed messages we can always use the narrates anyways.

Therealdoooc213 commented 1 week ago

Why not display full message as a baloon instead? It should wrap anyway

Look back on the previous conversation

Archanial commented 1 week ago

Just display the message both as baloon and in chat. What's the issue with that? The idea of chatmessages is that you don't look at the chat.

EvilDragonfiend commented 1 week ago

Just display the message both as baloon and in chat. What's the issue with that? The idea of chatmessages is that you don't look at the chat.

You shouldn't know where that message comes from.

Archanial commented 1 week ago

You shouldn't know where that message comes from. So? You don't know where this message comes from because it is sent by admins. If anything you could add like "..." at the start and do italics to differentiate this message from the rest.