search

BeeStation / BeeStation-Hornet

99.95% station. 0.05% bees
https://beestation13.com
GNU Affero General Public License v3.0
200 stars 682 forks source link

Update smartfridge.dm #11875

Closed Rukofamicom closed 1 week ago

Rukofamicom commented 1 week ago

About The Pull Request

Reduces the maximum storage of smartfridges from 6000 to 1200

Why It's Good For The Game

It takes about 1500 explosives stored in the same place to crash the server. Making it possible to store extremely excessive amounts of produce makes this possible. 300 is plenty for roundstart storage, and 1200 is plenty for upgraded storage - there is no situation in which the chef will need more food or crew will need more weaponized produce stored all in the exact same location.

This extends to the subtypes as well, so this will likewise apply to Xenobiology and their extracts which also have the potential for game crashing explosions that haven't been realized yet. I suspect Xenobiology will feel this change the most.

Testing Photographs and Procedure

image

Changelog

:cl: tweak: smart fridges now hold 300 x tier of matter bin items, bringing their maximum storage down from 6000 to 1200. This was done to help reduce/prevent accidental server crashes caused by stockpiling of explosives. Said crashes are not always the fault of the person stockpiling. /:cl:

Rukofamicom commented 1 week ago

This is here only if we can't come up with a more elegant solution within a reasonable time

mystery3525 commented 1 week ago

Dare I say speedmerge for the exploitability

MarkusLarsson421 commented 1 week ago

Chemistry might be affected, I can easily fill the fridge with 300 pills on almost round-start.

RDS88-beeman commented 1 week ago

Xenobiology will definitely feel this the most, but as I understand, it's not reasonably possible to crash this with a slime smartfridge, since you couldn't prime 1200 oil extracts before they started going off.

Granted, there is always a solution to the problem, so for my fellow xenobiologists I make the suggestion: More fridges.

Rukofamicom commented 1 week ago

Better solution arrived quickly so this PR is not necessary