search

BeeStation / BeeStation-Hornet

99.95% station. 0.05% bees
https://beestation13.com
GNU Affero General Public License v3.0
200 stars 682 forks source link

Worlds most important mapping change (makes APC on Rad stop floating) #11881

Closed llol111 closed 5 days ago

llol111 commented 1 week ago

About The Pull Request

Fixes APCs on Radstation floating (replaces incorrect facing APC in Vault, Lawyers, EVA with correct ones)

Why It's Good For The Game

Floating APC bad

IJAOF2N

Testing Photographs and Procedure

images ![OJKpWtd](https://github.com/user-attachments/assets/73c0fc00-6b83-4250-b93b-847cd3338b56) ![qyjNPY5](https://github.com/user-attachments/assets/156beab9-a5cf-4dc4-880a-97a71487c247) ![PoxB4Rn](https://github.com/user-attachments/assets/584ca3a1-2b74-4ea3-b8a4-b83609fdd1db)

Changelog

🆑llol111 fix: [RadStation] Fixes Floating APCs /:cl:

PowerfulBacon commented 6 days ago

Huh... The unit tests should be catching these

Looks like it was never enabled for APCs.

If you want another relatively easy PR to do, then copy and paste one of the directional mapping unit tests and change them to work on APCs as well, then this problem can never happen again.