search

BeeStation / BeeStation-Hornet

99.95% station. 0.05% bees
https://beestation13.com
GNU Affero General Public License v3.0
200 stars 682 forks source link

Update CONTRIBUTING.md to ensure ports highlight original content #11890

Open PowerfulBacon opened 5 days ago

PowerfulBacon commented 5 days ago

About The Pull Request

Large ports must now include details of which parts are original code, to make reviewing easier.

Why It's Good For The Game

When it comes to ports, the most likely thing to fail is the original code (since the TG code already has had significant testing on TG).

To make reviewing easier, contributors porting code from another codebase should indicate all the parts of their PR that is original code.

Testing Photographs and Procedure

N/A

Changelog

:cl: code: (Github) Large ports must now indicate which part of their port is original code. /:cl:

Archanial commented 1 day ago

I don't think it makes reviewing things easier, but it does make porting harder

PowerfulBacon commented 1 day ago

It makes reviewing significantly easier, TG has relatively good code quality and most of the time just needs a quick pass. The thing I'm actually looking out for is when someone has done original code, since that's usually the stuff that is most likely to have faults with it.