Adds Combat mode, rclick functionality

Tsar-Salat commented 4 days ago

About The Pull Request

This adds right-click functionality through the addition of the combat mode system.

Changes are as listed:

Major Codebase changes

Disarm and Grab Intents have been removed.
Diametric intents (harm/help) are not combat mode. Toggled by F or 4.
Context menu now appears on shift+rclick (like examine)
Disarm functionality has now been moved to rclick, whether CM is active or not
Grabbing has been centralized in its hotkey ctrl-click

Functional Item changes

Ninja Dash now activates via right-click
M90 grenade launcher activates through right click rather than toggle
Health analyzer now scans health with left click, chemicals with right click
Jumpsuits change suit sensors through right-click
Airlocks are now welded through rightclick
Reagent splashing is done through right click
RCDs deconstruct through rclick
Syringes now lclick to inject, rclick to draw
washingmachines now use rclick to start
stack splitting now uses rclick
hookshotguns use rclick instead of toggle
deconstructing windows, tables, chairs is done through rclick with appropriate tools
secure lockers are now (un)locked through rclick
gas canisters are repaired on lclick and deconstructed on rclick
right clicking a reagent container will now set it to its previous transfer amount
Screwdrivers can now be put in autolathes through lclick, maintenance through rclick
girders can be built by rclicking a turf with a sheet of iron (allowing building multiple at the same time)
Most previously rotatable structures or machines can now be rotated through mouseclick. Left for Counterclockwise, right for clockwise.
closet wrench actions moved to rclick
chemistry machines use rclick to add/remove their beakers
Kinetic Crusher projectiles are now fired on rclick
ID Painter now lets your remove IDs/PDA through rclick

Ports:

- https://github.com/tgstation/tgstation/pull/56601 - https://github.com/tgstation/tgstation/pull/56636 - https://github.com/tgstation/tgstation/pull/56667 - https://github.com/tgstation/tgstation/pull/56699 - https://github.com/tgstation/tgstation/pull/56700 - https://github.com/tgstation/tgstation/pull/56779 - https://github.com/tgstation/tgstation/pull/56781 - https://github.com/tgstation/tgstation/pull/56811 - https://github.com/tgstation/tgstation/pull/56813 - https://github.com/tgstation/tgstation/pull/56816 - https://github.com/tgstation/tgstation/pull/56829 - https://github.com/tgstation/tgstation/pull/56846 - https://github.com/tgstation/tgstation/pull/56864 - https://github.com/tgstation/tgstation/pull/56865 - https://github.com/tgstation/tgstation/pull/57214 - https://github.com/tgstation/tgstation/pull/57617 - https://github.com/tgstation/tgstation/pull/57788 - https://github.com/tgstation/tgstation/pull/57837 - https://github.com/tgstation/tgstation/pull/57841 - https://github.com/tgstation/tgstation/pull/57881 - https://github.com/tgstation/tgstation/pull/58124 - https://github.com/tgstation/tgstation/pull/58270 - https://github.com/tgstation/tgstation/pull/58523 - https://github.com/tgstation/tgstation/pull/58774 - https://github.com/tgstation/tgstation/pull/58802 - https://github.com/tgstation/tgstation/pull/58830 - https://github.com/tgstation/tgstation/pull/59508 - https://github.com/tgstation/tgstation/pull/59656 - https://github.com/tgstation/tgstation/pull/59814 - https://github.com/tgstation/tgstation/pull/60653 - https://github.com/tgstation/tgstation/pull/60990 - https://github.com/tgstation/tgstation/pull/61275 - https://github.com/tgstation/tgstation/pull/61795 - https://github.com/tgstation/tgstation/pull/62949 - https://github.com/tgstation/tgstation/pull/63038 - https://github.com/tgstation/tgstation/pull/64441 - https://github.com/tgstation/tgstation/pull/64482 - https://github.com/tgstation/tgstation/pull/64724 - https://github.com/tgstation/tgstation/pull/64939 - https://github.com/tgstation/tgstation/pull/64964 - https://github.com/tgstation/tgstation/pull/65353 - https://github.com/tgstation/tgstation/pull/65978 - https://github.com/tgstation/tgstation/pull/66038 - https://github.com/tgstation/tgstation/pull/66928 - https://github.com/tgstation/tgstation/pull/72463 - https://github.com/tgstation/tgstation/pull/72959 - https://github.com/tgstation/tgstation/pull/76057

Why It's Good For The Game

Intents are by-and-large not a very well written system. The "grab" intent, for instance, has had a hotkey for years on ctrl-click.

The large goal of this PR is to address two fundamental issues:

The current intent check system, which almost entirely relies on if a character is or is not on help or harm mode, to determine that players intention.
The clunkiness of actual systems that DO fully utilize the intent system

For the first issue, nearly all of our intent checks in the codebase are just diametric checks for if a player is in harm or help mode. Grab is only checked when checking grab_state, which is attached to attack_hand, otherwise you can basically forget about the intent and just use the ctrl hotkey. Disarm is in an even worse boat, its basically Harm Jr. in that players in combat will primarily be on harm while in combat and be spam-switching between the two only for the purpose of trying to stun them on a wall, table, or mob.

For the second issue, the most notable use of intents is martial arts. This is not to the boon of martial arts either, as the combination of moves that you have to do mid-combat is not very well done.

Allowing players to free up their mouse instead of the specific intents gives coders a lot more room and buttons to work with, and allow simplification for needlessly complex tasks like martial arts or construction.

Testing Photographs and Procedure

Screenshots&Videos

rclick welding https://github.com/user-attachments/assets/a57beea5-e2fc-4a6f-ada5-8157d5f468ca lclick/rclick syringes https://github.com/user-attachments/assets/24dbf3ec-9cf3-4f29-8442-86063871daf1 grab states https://github.com/user-attachments/assets/f967f636-702e-432a-bca3-d63fcad7b1ce RCD rclick deconstruction https://github.com/user-attachments/assets/2ff9beba-18e2-4ee7-80cb-04fd66c104e4 generic structure deconstruction https://github.com/user-attachments/assets/98534cc5-569b-46ef-9112-2e16a07425ea CW/CCW mouse rotation https://github.com/user-attachments/assets/b8cfabca-352a-4d9a-a08d-55bdf6007236 rclick girder construction https://github.com/user-attachments/assets/b8b80e36-f3d7-4c2a-b978-64f258750114

Changelog

:cl: rkz, Qustinnus, Mothblocks, TJatPBnJ, IndieanaJones, KathyRyals, Arkatos, norill, Fikou, dragomagol, SgtHunk, JJRCop, ninjanomnom, cacogen, Timberpoes, LemonInTheDark, Ghommie, Sealed101, Ghilker, TheBonded, Timothymtorres, CameronWoof, ArcaneDefence, BurgerLUA, OneAsianTortoise, vincentiusvin, itseasytosee, AnturK add: Adds combat mode refactor: refactored syringe code to use flags tweak: clicking on the turf of a airlock while combat mode is off will now close the airlock. No more pixel hunting! balance: buffs to hook shotgun in addition to rclick functionality code: renames RemoveComponent, component destroy will no longer runtime when parent is null refactor: refactored simple rotation component fix: fixed abandoned crates to not try to kill you if you perform actions on them AFTER they are unlocked code: introduced variable weapon attack speed. No weapon utilizes this yet but admins can now varedit items to attack faster/slower. code: unit tests reagent container transfer amounts /:cl: