BeeStation / BeeStation-Hornet

99.95% station. 0.05% bees
https://beestation13.com
GNU Affero General Public License v3.0
200 stars 682 forks source link

Unique Heretic Ascension Announcements #11925

Open Absolucy opened 7 hours ago

Absolucy commented 7 hours ago

About The Pull Request

Port of https://github.com/tgstation/tgstation/pull/82878

Music by @flleeppyy, and you can listen to them out-of-game here: https://flleeppyy.bandcamp.com/album/ss13-heretic-ascension-sounds

Also refactored how heretic ascension announcement works - it's a part of the /datum/heretic_knowledge/final/on_finished_recipe() proc now, and each path's subtype just sets the announcement_text and announcement_sound vars.

Why It's Good For The Game

Adds extra flavor and spice to the game for important events, much better than the overused generic "space-time anomalies" announcement.

Testing Photographs and Procedure

Screenshots&Videos me when i dig out a 514 build out of the depths of hell for sound effects https://github.com/user-attachments/assets/07006eb7-7812-4199-855b-49cea17d3c89

Changelog

:cl: Flleeppyy, Absolucy sound: Added unique announcement jingles to each heretic path's ascension, replacing the old "space-time anomalies detected" announcement. refactor: Cleaned up some repetitive code related to heretic ascension announcements. /:cl:

Fronsis commented 6 hours ago

Same as what said above, when you first ported it to Monke i thought it looked super neat, thanks for bringing it up!

Absolucy commented 4 hours ago

@Rukofamicom

https://github.com/user-attachments/assets/07006eb7-7812-4199-855b-49cea17d3c89