BeeStation / BeeStation-Hornet

99.95% station. 0.05% bees
https://beestation13.com
GNU Affero General Public License v3.0
199 stars 683 forks source link

[Bug]: Timestop is smaller #11973

Open RDS88-beeman opened 16 hours ago

RDS88-beeman commented 16 hours ago

BYOND Version

No response

Round Date

2024/12/01

Round ID

50846

Test merges

#9124: 'Enable serverside 515.1614' by Crossedfall at commit 1b8f225789 #10897: '[PORT] Follows up TG's atom_hud system' by EvilDragonfiend at commit 51f8edef4f

Describe the bug

As of recent PRs, the timestop effect used in wizard spells and xenobiology is 3x3, while both the graphic and prior effect was 5x5.

What did you expect?

I expected the timestop effect to be 5x5

Reproducible steps

  1. Create a timestop effect
  2. Observe the smaller range of the stun and visual effect
PowerfulBacon commented 16 hours ago

This is likely an accidental port from TG since I heard someone made an ided PR there to make it smaller. Not sure what is likely to have caused it

PowerfulBacon commented 16 hours ago

It's possible that this effects all fields, including timestop, proximity and peacekeeper fields

RDS88-beeman commented 15 hours ago

it's probably the proximity PR, like a rounding error or some shit

PowerfulBacon commented 14 hours ago

In Byond, range works as 0: 1x1 1: 3x3 2: 5x5

It may have been changed with this to: 0: Invalid 1: 1x1 2: 3x3