search

BeeStation / BeeStation-Hornet

99.95% station. 0.05% bees
https://beestation13.com
GNU Affero General Public License v3.0
200 stars 682 forks source link

Orbit Menu Runtimes #8910

Closed PowerfulBacon closed 1 year ago

PowerfulBacon commented 1 year ago

Occurance Details

Round Date: 2023-04-21

Round ID: 43693

Runtime Information:

[15:08:16] Runtime in job.dm, line 104: job name Personal AI is not valid
proc name: GetJob (/datum/controller/subsystem/job/proc/GetJob)
usr: #Redacted#/(#Redacted#)
usr.loc: (Robotics Lab (166, 119, 2))
src: Jobs (/datum/controller/subsystem/job)
call stack:
Jobs (/datum/controller/subsystem/job): GetJob("Personal AI")
/datum/orbit_menu (/datum/orbit_menu): ui data(#Redacted# (/mob/dead/observer))
/datum/tgui (/datum/tgui): get payload(null, 1, 1)
/datum/tgui (/datum/tgui): open()
/datum/orbit_menu (/datum/orbit_menu): ui interact(#Redacted# (/mob/dead/observer), /datum/tgui (/datum/tgui))
#Redacted# (/mob/dead/observer): Orbit()
Orbit (/atom/movable/screen/ghost/orbit): Click(null, "mapwindow.map", "icon-x=21;icon-y=10;left=1;scr...")
PowerfulBacon commented 1 year ago

Honestly, GetJob shouldn't runtime when it fails.

EvilDragonfiend commented 1 year ago

Being handled in

EvilDragonfiend commented 1 year ago

It should runtime because their job was given wrongly because of shitcode. The runtime job shouldn't ever never exist.

PowerfulBacon commented 1 year ago

This happens in a massive number of places. This also occurs occurs in mail.

proc name: GetJob (/datum/controller/subsystem/job/proc/GetJob)
src: Jobs (/datum/controller/subsystem/job)
call stack:
Jobs (/datum/controller/subsystem/job): GetJob("Lavaland Syndicate")
the mail crate (/obj/structure/closet/crate/mail/economy): populate(12)
the mail crate (/obj/structure/closet/crate/mail/economy): Initialize(0)
Atoms (/datum/controller/subsystem/atoms): InitAtom(the mail crate (/obj/structure/closet/crate/mail/economy), 0, /list (/list))
the mail crate (/obj/structure/closet/crate/mail/economy): New(0)
the supply shuttle (/obj/docking_port/mobile/supply): create mail()
the supply shuttle (/obj/docking_port/mobile/supply): initiate docking(Transit for supply/supply shut... (/obj/docking_port/stationary/transit))
the supply shuttle (/obj/docking_port/mobile/supply): enterTransit()
the supply shuttle (/obj/docking_port/mobile/supply): check()
Shuttle (/datum/controller/subsystem/shuttle): fire(0)
Shuttle (/datum/controller/subsystem/shuttle): ignite(0)
Master (/datum/controller/master): RunQueue()
Master (/datum/controller/master): Loop()
Master (/datum/controller/master): StartProcessing(0)
EvilDragonfiend commented 1 year ago

Yeah, like I said, these jobs shouldn't be given at all, and it's handled in the PR.

github-actions[bot] commented 1 year ago

This issue has been inactive for long enough to be automatically marked as stale. If this was a bug report and hasn't been addressed yet, and is still a problem, please don't hesitate to notify a maintainer.