search

BeeStation / BeeStation-Hornet

99.95% station. 0.05% bees
https://beestation13.com
GNU Affero General Public License v3.0
200 stars 681 forks source link

Asset loading is horribly slow #9275

Open PowerfulBacon opened 1 year ago

PowerfulBacon commented 1 year ago

We spend an insane amount of init time in the asset subsystem, we should probably tone some of this down or make it lazilly loaded. image

Gags is also not off the hook for being overly expensive. That would be far better as something in DM rather than a json file.

itsmeow commented 1 year ago

Asset loading is slow because it has to make icons for like 5000 items (every R&D module, every vending machine item)

This is why we cache them cross-round.

EvilDragonfiend commented 1 year ago

And it already does lazy load.

PowerfulBacon commented 1 year ago

https://github.com/tgstation/tgstation/pull/63503/files Do we have this?

PowerfulBacon commented 1 year ago

image Its almost as expensive as initialising the entire world

EvilDragonfiend commented 1 year ago

we do have. but some assets are missing crossround = TRUE.

github-actions[bot] commented 1 year ago

This issue has been inactive for long enough to be automatically marked as stale. If this was a bug report and hasn't been addressed yet, and is still a problem, please don't hesitate to notify a maintainer.

itsmeow commented 9 months ago

Partially fixed by #10404 md5asfile is still particularly bad, also it inits and then qdels vending machines still, which is problematic.