BeeStation / NSV13

NSV13, a Ship-to-ship Combat SS13 Server
GNU Affero General Public License v3.0
119 stars 257 forks source link

Gauss LAZYFIND doesn't seems to do anything anymore #2263

Open Bobbanz1 opened 1 year ago

Bobbanz1 commented 1 year ago

Round ID:

Testmerges:

Reproduction:

Issue discovered whilst doing something for Sophie's Broadside PR, I also managed to reproduce the issue in the master branch on my own fork so it's something that's in our current master branch

I have found this issue occurring here https://github.com/BeeStation/NSV13/blob/a68b9633c95f7477bbdbdf897f3082506d85dae6/nsv13/code/modules/munitions/ship_weapons/ballistic_weapons/gauss_gun.dm#L414

Instead of stopping the player from trying to load an empty crates worth of content into the gauss rack, it merely just continues on like there wasn't any conditional statement supposedly preventing people from loading an empty crate!

How to reproduce this issue: Grab an empty crate. Click drag it onto the Gauss Rack. Watch as a progress bar appears and no mentions of "There's nothing in this crate you can load onto the gauss rack" is in sight.

Bobbanz1 commented 1 year ago

https://user-images.githubusercontent.com/59128051/210432562-1b91cbd0-a882-418b-a019-9f90c242f5f3.mp4