BeeStation / NSV13

NSV13, a Ship-to-ship Combat SS13 Server
GNU Affero General Public License v3.0
118 stars 255 forks source link

Fixes the "eternal return jump" bug #2610

Closed DeltaFire15 closed 6 months ago

DeltaFire15 commented 7 months ago

About The Pull Request

Title. I got to stare at the runtimes of it happening, and it appears like it is caused by jumping with a disabled thirring drive (which usually gets caught for normal jumps), causing jump speed to be 0, which causes a divby0 error and thus kills the proc.

This makes jumps default to speed 1 (very slow) if the proc chain gets that far with speed <= 0, as that must be a manually called case (no active pylons on thirring should be caught in several prior locations if not directly called / overridden)

Why It's Good For The Game

Fix man good.

Testing Photographs and Procedure

No.

Changelog

:cl: fix: Being recalled with an inactive thirring drive should no longer trap the ship in the darkness between stars. /:cl: