BeeStation / NSV13

NSV13, a Ship-to-ship Combat SS13 Server
GNU Affero General Public License v3.0
118 stars 255 forks source link

Relayed BSA is more 'fun' and also random fixes. #2628

Closed DeltaFire15 closed 5 months ago

DeltaFire15 commented 5 months ago

About The Pull Request

While the (true) BSA has a lot of oomph on the overmap itself, its actual effects when relayed are somewhat less interesting as it's effectively just a hitscan-penning NAC that leaves no trace once it passed. This gives it a large explosion and some rather unpleasant effects on direct hits instead. I considered letting it actually truncate ships & spacing a line, but given we do have pvp content on the overmap sometimes (or if some bus contains a foe with a BSA), that'd be a bit rude . Also is similar to the effects when someone fires the thing with the shutters closed.

Also fixes a lot of random things that runtime since I test with pause on runtime enabled and also look at logs sometimes. Sidetracking my beloved.

Why It's Good For The Game

Explosions are nice.

Also fix man good.

Testing Photographs and Procedure

No.

Changelog

:cl: balance: The BSA now goes kaboom when relayed instead of being essentially a ghost NAC shell. fix: The Eclipse no longer spawns a borg module that should never exist outside of mobs. fix: DNA no longer has some super weird code for flavor text, instead copying the one of the source mob. tweak: You can no longer stack interactions on walls. This is to prevent a runtime from actions that modify the type of them (deconstruction mainly). fix: Paper no longer runtimes if you do not have a pen in hand (???). fix: Traders no longer do some cursed things to create their trade items, instead using the all-powerful initial(). fix: The stormdrive no longer runtimes if it has zero gas in it. fix: Some squad assignment stuff shouldn't try to use a list as datum anymore. /:cl: