BeeStation / NSV13

NSV13, a Ship-to-ship Combat SS13 Server
GNU Affero General Public License v3.0
118 stars 255 forks source link

Replaces generic HOS spacesuit with nerfed Mjolnir #2636

Closed BlueHNT closed 1 month ago

BlueHNT commented 5 months ago

About The Pull Request

Replaces generic HOS space suit with the old Mjolnir nerfed for modern NSV.

Why It's Good For The Game

Generic HOS suit is a copy paste from Bee station. This PR would return the Mjolnir which has a pretty legendary history on NSV back into the game in a nerfed version that doesn't protect from fire and has armor about the same as normal security hard suit.

This would replace the hard suit which currently makes you near invincible in space with a lighter still bulky version, which has the option to give you normal running speed after returning from space. So, it would pretty much replace protection for mobility while still keeping the HOS suit slightly better than normal security suit due to the mobility.

Testing Photographs and Procedure

Screenshots&Videos ![image](https://github.com/BeeStation/NSV13/assets/79374236/71275e40-0363-47f4-9811-9f625a018590) ![image](https://github.com/BeeStation/NSV13/assets/79374236/3235c00a-7902-48d5-9ab2-609a9c263a1b) ![image](https://github.com/BeeStation/NSV13/assets/79374236/2697d28c-86a3-454a-a9a2-8311bbe216e8) ![image](https://github.com/BeeStation/NSV13/assets/79374236/c59fe627-a028-4943-b9a2-ebb8f1c4b675) ![image](https://github.com/BeeStation/NSV13/assets/79374236/1f174fde-8b6a-49ef-95f1-9a12384181e2) ![image](https://github.com/BeeStation/NSV13/assets/79374236/d6527c95-e076-41e0-ab9b-d8eeb97289b1)

Changelog

:cl: balance: rebalanced Peacekeeper suit to be usable in normal round and removed thermal insulation fix: fixed Peacekeeper suit sprite: replaced old mjolnir sprites with new red ones. :cl:

SerynEngi commented 5 months ago

I really don't have many comments on the armor itself. The swap of mobility VS tankiness is a sec main thing. I do have a couple comments on the armor values. The large amount of blue also brings to mind the ERT Medic armor.

Energy: Electrical resistance, Specifically against things like tesla shocks and wires. There is no reason to increase this with this armor, I highly recommend knocking this back down to the original value as there isn't a realistic scenario where a HOS would need this.

Bullet: I'd up that to 50 in this particular case. Its a small resistance up, but its not terrible, and makes it better than the boarding armor.

Bomb: I'm not sure that it needed to be nerfed this hard unless regular HOS armor is knocked down this hard. I'd set it to 25 so a random explosion on the ship doesn't down the HOS while he's fighting.

BlueHNT commented 5 months ago

I really don't have many comments on the armor itself. The swap of mobility VS tankiness is a sec main thing. I do have a couple comments on the armor values. The large amount of blue also brings to mind the ERT Medic armor.

Energy: Electrical resistance, Specifically against things like tesla shocks and wires. There is no reason to increase this with this armor, I highly recommend knocking this back down to the original value as there isn't a realistic scenario where a HOS would need this.

Bullet: I'd up that to 50 in this particular case. Its a small resistance up, but its not terrible, and makes it better than the boarding armor.

Bomb: I'm not sure that it needed to be nerfed this hard unless regular HOS armor is knocked down this hard. I'd set it to 25 so a random explosion on the ship doesn't down the HOS while he's fighting.

The armor values are an exact copy of security eva suit, but I can see where you're going with this.

BlueHNT commented 4 months ago

Next issue:

I need people who are aware of the current armor values which tend to be 60 for HOS armors similar to the old hard suit.

What should be the value of the modular hard suit and what should be the slowdown?

Numbers I had in mind would be putting the armor value to 50 and leaving the slowdown be at 0. Making it a bit speedier, at the cost of not being able to stop bullets too well.

Someone (forgot who) said I should make the slowdown around 0.3-0.5 and put it back up to 60 bulletproofing.

I want some thoughts on this for reference points.

DeltaFire15 commented 4 months ago

Also doesn't support digitigrade like syndisuit does, so needs supports_variations = NO_VARIATION

BlueHNT commented 4 months ago

Also doesn't support digitigrade like syndisuit does, so needs supports_variations = NO_VARIATION

I have no clue what that is, but I'll add it.

DeltaFire15 commented 4 months ago

I have no clue what that is, but I'll add it.

Stuff related to fancy legs. (Well technically human legs are the weird ones on an evolutionary standpoint, but shh)

BlueHNT commented 3 months ago

There's a merge issue that I am unaware of. Send help.

BlueHNT commented 2 months ago

Updated master.