This PR improves the code for ammo racks a bit, allows for loading ammo racks via attackby, adds some sanity checks to ammunition exiting ammo racks, and adjusts jamming SFX to only play when the ammo rack first jams. It also adjusts the to_chat messages to hopefully be a bit clearer.
It also moves ammo rack code into its own DM file, moves the circuits into the NSV circuit file, and organizes the code a bit.
Why It's Good For The Game
This fixes a couple of edge cases with racks (such as getting nulls in the ammo list, oil sometimes not fully repairing racks). It also removes the SFX-spam capability of jammed ammo racks, and hopefully cuts down on accidentally disassembling racks while trying to unjam them.
:cl:
add: Ammo racks may now be loaded by attacking them with ammunition
tweak: Jam SFX now plays on jam instead of on load attempt
fix: Fixes a few ammo rack-related edge cases
/:cl:
About The Pull Request
This PR improves the code for ammo racks a bit, allows for loading ammo racks via attackby, adds some sanity checks to ammunition exiting ammo racks, and adjusts jamming SFX to only play when the ammo rack first jams. It also adjusts the to_chat messages to hopefully be a bit clearer.
It also moves ammo rack code into its own DM file, moves the circuits into the NSV circuit file, and organizes the code a bit.
Why It's Good For The Game
This fixes a couple of edge cases with racks (such as getting nulls in the ammo list, oil sometimes not fully repairing racks). It also removes the SFX-spam capability of jammed ammo racks, and hopefully cuts down on accidentally disassembling racks while trying to unjam them.
Testing Photographs and Procedure
Screenshots&Videos
  Changelog
:cl: add: Ammo racks may now be loaded by attacking them with ammunition tweak: Jam SFX now plays on jam instead of on load attempt fix: Fixes a few ammo rack-related edge cases /:cl: