BeeStation / NSV13

NSV13, a Ship-to-ship Combat SS13 Server
GNU Affero General Public License v3.0
115 stars 257 forks source link

Fixes Shells are not appropriately handling the presence of powder bags. #2659

Closed IndusRobot closed 2 weeks ago

IndusRobot commented 1 month ago

About The Pull Request

Fixes a long standing issue where gunpowder is being packed directly into the shell by powder gates, allowing "pre-loading" to occur where it shouldn't via deconstruction. Feeding the shell now modifies its speed directly before it's sent to the weapon turret.

If you're loading and using the deck turret under normal conditions, nothing changes.

Why It's Good For The Game

Fixes https://github.com/BeeStation/NSV13/issues/1385

Testing Photographs and Procedure

Screenshots&Videos https://github.com/BeeStation/NSV13/assets/22532898/2bdfeac7-16ac-4c9d-9247-1bb935eddd19 Since gunpowder will be held in the payload gate until used, dismantling it will return your gunpowder without modifying the shell ![image](https://github.com/BeeStation/NSV13/assets/22532898/f099ca55-4682-4e60-a506-8f3847a0d945)

Changelog

:cl: fix: Fixed shells are not appropriately handling the presence of powder bags /:cl: