BeeStation / NSV13

NSV13, a Ship-to-ship Combat SS13 Server
GNU Affero General Public License v3.0
115 stars 257 forks source link

[WIP] Make big ships feel tankier #2664

Open DuskLight9978 opened 1 month ago

DuskLight9978 commented 1 month ago

About The Pull Request

So big ships felt weak as they entered SScrit quickly and struggled to exit SS crit. This addresses that.

Atlas unchanged repair rate: .27% per pump at max (For reference) Whips unchanged repair rate: .33% per pump at max (for reference)

Galactical changed repair rate: .13%> .51% per pump at max. Easily lowerable after review of live rounds Tycoon&&Gladius changed repair rate: .19%> .50% per pump at max. Easily lowerable after review of live rounds

Why It's Good For The Game

beeg ships should consistently feel beeg and not just fold like a deck of cards. This attempt to address it via pumps

Testing Photographs and Procedure

Screenshots&Videos Put screenshots and videos here with an empty line between the screenshots and the `
` tags.

Changelog

:cl: tweak: Pumps bonked to provide bigger ships better values balance: Beeg ships should now feel Beeg /:cl:

Bokkiewokkie commented 1 month ago

Larger ships do not struggle with sscrit if they are not being shot. If you are being shot, not being able to repair well is sort of the point.

This PR has two effects: a) it messes with APNW resource drain badly, aka the reason the check that sets weight class to 10 exists (the APNW RU generation cannot keep up with repair drains this high)

b) These repair rates are unneccessary. You are tripling the pump generation per tick for vessels like the Tycoon, and quadrupling it for the Galactica. If the armor pump system is operated properly, reads, repair efficiency zones, stress, and pump sector allocation are used, you already have capability to absorb damage reasonable for ships of their class, or even above. Hull in this context should not be the most efficient line of defense, which this PR is dangerously close to causing (due to consistent repair speed vs. the scaling but inconsistent plate curves).

Yeah the exact balancing is something I've already discussed with them, and it's why the PR is marked as WIP and DNM. I also heard a suggestion to take a different approach, instead making a variant of the armor pump with higher loads in mind, which I like more than the solution presented in this PR.

Altangy commented 1 month ago

Larger ships do not struggle with sscrit if they are not being shot. If you are being shot, not being able to repair well is sort of the point.

This is flat out false. Galactica has always struggled with SS crit

b) These repair rates are unneccessary. You are tripling the pump generation per tick for vessels like the Tycoon, and quadrupling it for the Galactica. If the armor pump system is operated properly, reads, repair efficiency zones, stress, and pump sector allocation are used, you already have capability to absorb damage reasonable for ships of their class, or even above. Hull in this context should not be the most efficient line of defense, which this PR is dangerously close to causing (due to consistent repair speed vs. the scaling but inconsistent plate curves).

I don't know the exact math but honestly? I don't need to. Combat has and always will be a race who's time is affected by the helm's ability to dodge with a 10 minute recoverable invulnerability phase.

Pockets-byte commented 1 month ago

I can tell you that waiting for galactica's armor to regen is godawful. it takes FOREVER. half of playing galactica is sitting in eco waiting for the armor to get up to half so we can jump to rubi consequences be dammed