search

BeeStation / NSV13

NSV13, a Ship-to-ship Combat SS13 Server
GNU Affero General Public License v3.0
115 stars 257 forks source link

[TM Probably] Sabre insanity, also known as one proc adjustment that might possibly fix stuff #2666

Open DeltaFire15 opened 1 month ago

DeltaFire15 commented 1 month ago

About The Pull Request

There is some bug going on with miner sabres sometimes getting nullspaced and I spent hours without finding out why. The one part of the entire proc chain that is basically always questionable is the weird ships[] list so I passed some better values for now and we'll see if that fixes it. TM this please. We'll see if someone gets nullspaced with this and if someone does I go back to the mines.

Why It's Good For The Game

Fix man good.

Changelog

:cl: fix: Possibly fixes some weird Sabre behavior. fix: Also makes one single gun check of the plasma caster slightly safer. /:cl:

DeltaFire15 commented 1 month ago

Of course this PR has 666 in its number..

DeltaFire15 commented 1 month ago

do you want to keep this testmerged until we find the issue? Otherwise I'd like for you to move your comments to a new issue instead so someone else can potentially look at it instead.

Essentially, this might resolve it or it might not. It's the only place I found that looked potentially volatile, and I wasn't able to reproduce how to trigger the issue in the first place, despite someone managing to trigger it in the first system without having jumped. It also didn't cause a runtime during the time I helped someone out on the server.

If it doesn't happen again, this was probably it, if it does, I'll have to check vars again and question them aswell so I can have some different occurances to compare.