The reminder stacks were increased but the increase would not be commnunicated to the players if they were in combat during it, leading to auto recall announcements being missable.
Opening this as draft for now in case I get sidetracked before I can properly rework it.
fixes #2672
Why It's Good For The Game
Players not knowing that auto recall is approaching is bad because surprise auto recall is lame. This makes sure that the time is always available to the players.
Testing Photographs and Procedure
Admin completed initial objectives, voted for extension, set next_objective_reminder low enough to get a reminder (got a reminder), spawned in a pirate fleet in current system, set next_objective_reminder low again, (got a reminder), set it low again (got the "recall delayed due to combat message"), waited 10 minutes, got auto recalled. (I believe the 10 minutes wait after the recall is delayed are not related to this PR.)
Changelog
:cl:
fix: Auto recall reminders now also get sent during combat
/:cl:
The reminder stacks were increased but the increase would not be commnunicated to the players if they were in combat during it, leading to auto recall announcements being missable.
Opening this as draft for now in case I get sidetracked before I can properly rework it.
fixes #2672
Why It's Good For The Game
Players not knowing that auto recall is approaching is bad because surprise auto recall is lame. This makes sure that the time is always available to the players.
Testing Photographs and Procedure
Admin completed initial objectives, voted for extension, set next_objective_reminder low enough to get a reminder (got a reminder), spawned in a pirate fleet in current system, set next_objective_reminder low again, (got a reminder), set it low again (got the "recall delayed due to combat message"), waited 10 minutes, got auto recalled. (I believe the 10 minutes wait after the recall is delayed are not related to this PR.)
Changelog
:cl: fix: Auto recall reminders now also get sent during combat /:cl: