BeeStation / NSV13

NSV13, a Ship-to-ship Combat SS13 Server
GNU Affero General Public License v3.0
115 stars 257 forks source link

Sort projectiles fx.dm better #2675

Open Kenionatus opened 3 weeks ago

Kenionatus commented 3 weeks ago

About The Pull Request

Should make it a bit less likely that people (like me) overlook some procs that were far away from their datum. Also turns some comments into doc comments. Only single character changes this time, no moving of comments (so code style stays the same as before). This now works because the extension is now fixed and propperly handles //! marked same line doc comments. (On the other hand, it might have broken /// above line doc comments? I don't think that really matters for this PR tho.) Also adds like one additional empty line somewhere for separation.

Why It's Good For The Game

Makes code easier to read.

Testing Photographs and Procedure

Screenshots&Videos VSCode tells me that the removals are all code movements instead of actual removal. ![image](https://github.com/BeeStation/NSV13/assets/54814353/dd0ccdca-49c4-49eb-b33c-0850c05e0b7f)

Changelog

:cl: refactor: projectiles_fx.dm should now be slightly more readable /:cl:

Kenionatus commented 3 weeks ago

Bruh, did the image upload not work? Hm, file is there, just the embedding is broken?

Ikalpo commented 6 days ago

Bruh, did the image upload not work? Hm, file is there, just the embedding is broken?

It's because you wrote between these lines

<details>
<summary>Screenshots&Videos</summary>
>>HERE<<
![image](https://github.com/BeeStation/NSV13/assets/54814353/dd0ccdca-49c4-49eb-b33c-0850c05e0b7f)

</details>