search

BeeStation / NSV13

NSV13, a Ship-to-ship Combat SS13 Server
GNU Affero General Public License v3.0
115 stars 257 forks source link

adds a warning noise when ships with shields take damage to the hull #2680

Closed Pockets-byte closed 3 weeks ago

Pockets-byte commented 3 weeks ago

About The Pull Request

there was an unused shield failure noise in the game files. it's used now

Testing Photographs and Procedure

Screenshots&Videos Put screenshots and videos here with an empty line between the screenshots and the `
` tags.

Changelog

:cl: add: added a warning sound for hull hits when the shields fail /:cl:

SerynEngi commented 3 weeks ago

I have nothing to say pertaining to whether or not we use this effect.

I've explained before that this variety of shield generator doesn't really have a down state except when it loses power. You already know that the shield is insufficient for the hit when you start taking the hits on the hull, so a "down" state is something I view as unneeded.

What I will say is that the effect isn't unused. This sound is straight from the PDSR.

PDSR

Pockets-byte commented 3 weeks ago

I have nothing to say pertaining to whether or not we use this effect.

I've explained before that this variety of shield generator doesn't really have a down state except when it loses power. You already know that the shield is insufficient for the hit when you start taking the hits on the hull, so a "down" state is something I view as unneeded.

What I will say is that the effect isn't unused. This sound is straight from the PDSR.

PDSR

I didn't actually check to see if it was used which is my bad, in this case all it does is play this sound when a ship with shields has the shields not stop something, with a fairly long cooldown(for sounds)- this would probably happen with the pdsr as well