BeeeBea / FastMove

Repo for the FastMove mod for mc1.20.1 Fabric/Quilt
Other
6 stars 3 forks source link

Roll occurs even while flying or swimming #7

Closed GalatynF closed 1 year ago

GalatynF commented 1 year ago

As the title says, pressing sneak always performs the roll as long as the player is not touching the ground, which is annoying when wanting to get to the bottom of a pool for example, and is extremely OP when flying as it essentially gives free boosting.

The check on line 226 of PlayerEntityMixin should probably be more restrictive, checking if :

GalatynF commented 1 year ago

And yes, someone already raised the issue with elytras but I wanted to address the source cause and add the water issue to that

BeeeBea commented 1 year ago

Thank you for the detailed issue!

This should now be fixed with version 1.0.4 :)