BeefreeSDK / beefree-sdk-npm-official

Official NPM package of Beefree SDK
https://developers.beefree.io
Apache License 2.0
19 stars 7 forks source link

Fix/merge tags type #75

Closed davidesamp closed 2 years ago

davidesamp commented 2 years ago

Description

This PR close the following issue https://github.com/BEE-Plugin/Bee-plugin-official/issues/72

Motivation and Context

Types for IMergeTag don't match documentation or HTML output

Usage examples

import BeePLugin from '@mailupinc/bee-plugin'

const mergeTags: IMergeTag[] = [{
  name: 'tag 1',
  value: '[tag1]'
}, {
  name: 'tag 2',
  value: '[tag2]'
}]

const beeConfig :IBeeConfig = {
  uid: 'test1-clientside',
  autosave: 15,
  language: 'en-US',
  mergeTags,
}

const template = { page: { ... } }

const beePlugin = new BeePlugin()
beePlugin.start(beeConfig, template, '', { shared: false })

Types of changes

github-actions[bot] commented 2 years ago

Code Coverage Report

Coverage after merging fix/merge-tags-type into master

84.00%
Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   index.ts50%7.89%61.97%..., 93, 94, 98, 99
src/services
   api.ts100%50%100%
   axios.ts100%100%100%
src/types
   bee.ts100%100%100%
src/utils
   Constants.ts100%100%100%
   utils.ts0%0%70.59%..., 8, 8, 9, 9