search

BeelGroup / Docear-Desktop

Docear's desktop version (GPL)
296 stars 90 forks source link

include Saxon to provide XSLT 2.0 processing #488

Closed ftes closed 7 years ago

ftes commented 8 years ago

This might better be merged upstream in Freeplane, I don't know what your policy is.

GeorgLink commented 8 years ago

Hi @ftes,

welcome to Docear. Thank you for creating a pull request.

To your question: yes, if you can provide improvements to Freeplane, that would be awesome. Docear is likely to get changes from Freeplane.

If you think the change should be integrated in Docear before we include a newer Freeplane version, then we can move forward with your pull request. From reviewing the pull request, I have a two questions.

  1. How can I reproduce the "error when exporting with .xsl files using 2.0 features"?
  2. The commit seems to include Saxon, but how is Saxon actually being used in Docear?

Looking forward to your response. Georg

ftes commented 8 years ago

1. Reproduce by exporting (Tools and Settings->Export->Export Map) as type latex input with cites and details. Under Windows 10 this results in an Export failed warning. The log shows an Unsupported XSL element 'result-document' exception thrown somewhere in com.sun.org.apache.xalan.internal.xsltc.trax....

The problem is that the Apache Xalan transformer, which is included in the JDK, does not support XSLT 2 features (see StackOverflow).

XSLT 2 features for exporting a map would

  1. be very handy to have (advanced string processing, ability to declare custom functions etc.) and
  2. are used by some of the export transformations included in FreePlane, e.g. the latex one mentioned above.

2. Saxon is an XSLT 2 capable transformer. The pull request also includes additional META-INF files that instruct the JDK to favour Saxon over Xalan for XSLT transformations.

buhtz commented 7 years ago

What is the status of the PR?

ftes commented 7 years ago

sorry, can be dropped

payload commented 7 years ago

I have this problem in 1.2 and am currently compiling docear myself, possibly merging this commit locally. Why dropping this PR?

buhtz commented 7 years ago

My reason to drop this is jast the age. The PR stands to long here without being merged.

Maybe it would help if you describe how this PR could help you. Then someone of the maintainers would accept the PR - maybe...

MariusWolf1991 commented 5 years ago

I have the same issue, please take up this PR again. I would save a lot of time if I could get my papers from Docear into latex more easily

Joeran commented 5 years ago

I wouldn't mind to merge / accept the PR. However, it seems to me that @ftes delete the request? At least, I can't find any option here on GitHub to see the code change and accept the PR.

MariusWolf1991 commented 5 years ago

in Files Changed, you can see the changes and you can download @ftes fork. Would that be enough, or does ftes has to open the PR again?

Joeran commented 5 years ago

i don't have time for this. if someone makes (again) a PR, and I just need to click a button to accept the request, then I can do that.

MariusWolf1991 commented 5 years ago

sorry, can be dropped

Can you please open the PR again? I don't know how to do it, and you have the code