BeelGroup / Docear4Word

Source code of Docear4Word. See http://www.docear.org/software/add-ons/docear4word/overview/ for more details.
18 stars 7 forks source link

Catch broken citation data #26

Closed Joeran closed 10 years ago

Joeran commented 10 years ago

If, for whatever reason, some data in a Word document is corrupted this might cause Docear4Word to crash

http://www.docear.org/support/forums/docear-support-forums-group3/bug-reports-forum6/docear4word-creating-citation-thread325.0/#postid-2317

better exception handling would be nice

simmotech commented 10 years ago

"Stop working correctly" would be a better phrase than "crash" since the latter implies that the host Word might crash and/or document might be lost which isn’t the case.

My suggestions:-

1) That some message is displayed even though we don’t know what the problem was

2) That the Undo should remove the “Inserting citation...” temporary message

Also in this case, it is not clear how the citation came to be nearly empty. This is first time I have seen this but if it seen again,

3) We could add some validation checking before passing to citeproc – in this case checking that an array of citation items exists.

Joeran commented 10 years ago

for as long as no other users have the same issue, i close the ticket