RT crashes when selecting "Camera standard or ICC" with non-existant profile

[Beep6581]

Originally reported on Google Code with ID 1045

What is the problem?
I have a Canon EOS Digital Rebel XSi (which is the US market name for the 450D).  If
I edit a photo and select "Camera standard or ICC" from the ICM Input Profile settings
then RT immediately exits to the desktop (presumably due to a crash).

What steps will reproduce the problem?
1. Double click a photo from the file browser to begin editing it.
2. Navigate to the "Input Profile" portion of the Color->ICM settings area.
3. Click on "Camera standard or ICC" (which isn't greyed out, even though there is
no profile for "Canon EOS Digital Rebel XSi" in /usr/share/rawtherapee/iccprofiles).
 RT crashes.

It's worth noting that if I copy "Canon EOS 450D.icc" to "Canon EOS Digital Rebel XSi.icc"
(which is sensible, since they're supposed to be the same camera) then the profile
gets applied and no crash occurs.

Click on the Preferences icon (top-right corner) > About > Version, and
paste all that here.

Branch: default
Version: 4.0.3.12
Changeset: ccb433ebf6e2
Compiler: GCC 4.5.2
Processor: undefined
System: Linux
Bit depth: 64 bits
Gtkmm: V2.24.0
Build type: Debug
Build flags: -g -O2
Link flags: -Wl,-Bsymbolic-functions
OpenMP support: ON
MMAP support: ON

Operating system and architecture (e.g. winXP-32, ubuntu-10.10-64):
ubuntu-11.04-64

Reported by perveilerj on 2011-10-14 20:17:34

[Beep6581]

Do you have an ICC profile for this camera in RTs' /iccprofiles directory?

Reported by michaelezra000 on 2011-10-14 20:25:53

[Beep6581]

As mentioned above (perhaps you just missed it):

"Click on "Camera standard or ICC" (which isn't greyed out, even though there is no
profile for "Canon EOS Digital Rebel XSi" in /usr/share/rawtherapee/iccprofiles). 
RT crashes.

It's worth noting that if I copy "Canon EOS 450D.icc" to "Canon EOS Digital Rebel XSi.icc"
(which is sensible, since they're supposed to be the same camera) then the profile
gets applied and no crash occurs."

So:
no profile = selectable radio button and crash
yes profile = selectable radio button and no crash

Reported by perveilerj on 2011-10-14 20:38:30

[Beep6581]

Indeed, thanks, I skipped that part as usually it is not populated...

Reported by michaelezra000 on 2011-10-14 20:50:27

[Beep6581]

Same here in Gentoo 64, RT crashes when selecting "Camera standard or ICC" in a clean
install, therefore not containing the iccprofiles dir or anything in it. Speaking of
which, imho that dir should exist by default even though it would be empty.

Reported by entertheyoni on 2011-10-15 22:19:18

• Status changed: Accepted
• Labels added: OpSys-Linux

[Beep6581]

Hombre, are you around? I guess the cmake scripts should be updated for the new dir,
and I guess you are our most experienced CMAKEr.

Reported by oduis@hotmail.com on 2011-10-16 09:41:20

• Labels added: 4.0

[Beep6581]

I'll look at it tonight.

Reported by natureh.510 on 2011-10-17 15:57:04

[Beep6581]

I think i've found the bug, but please check if the culprit is not the previous line.
See patch attached.

Feel free to commit it if it's okay.

Reported by natureh.510 on 2011-10-17 21:23:45

• Status changed: PatchSubmitted
• Labels added: Priority-Medium, OpSys-All
• Labels removed: Priority-Low, OpSys-Linux

---

• Attachment: AutoICCProfile.patch

[Beep6581]

Committed to DEFAULT.

Thanks for the fix Hombre! (Sorry, I'm a bit busy at the moment)

Reported by oduis@hotmail.com on 2011-10-18 19:36:44

[Beep6581]

Reported by oduis@hotmail.com on 2011-10-18 19:38:22

• Status changed: Fixed