White/black/green rectangles/squares/boxes appear in image

[Beep6581]

Originally reported on Google Code with ID 1084

White rectangles appear in the final image file. The problem does not appear if noise
reduction is not enabled. This has happened with multiple image files and with different
RawTherapee versions.

What steps will reproduce the problem?
1. Open the provided raw file
2. Apply the provided .pp3 file
3. Save the final image, and open it using any image viewer

Branch: default
Version: 4.0.3.0
Changeset: 977e9d748557
Compiler: GCC 4.6.1
Processor: undefined
System: Linux
Bit depth: 32 bits
Gtkmm: V2.24.2
Build type: Release
Build flags: -march=i686 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4
-D_FORTIFY_SOURCE=2
Link flags:  -Wl,-O1,--sort-common,--as-needed,-z,relro,--hash-style=gnu
OpenMP support: ON
MMAP support: ON

Arch Linux-32

Final image file with the problem:
http://i.imgur.com/kO2rs.jpg

Final image file but without noise reduction,
the rectangles are not visible:
http://i.imgur.com/IHFnD.jpg

Raw image file:
http://panuhorsmalahti.fi/IMG_0674.CR2

.pp3 file (save page as to download):
http://panuhorsmalahti.fi/IMG_0674_noise_reduction.jpg.out.pp3

Reported by nawitus on 2011-10-31 17:05:30

[Beep6581]

What does this have to do with 1052?

Reported by ejm.60657 on 2012-03-18 21:57:25

[Beep6581]

1052. See #24 and #28. So here is fix but 1052 reindroduce same bug.

Reported by GreatBull69 on 2012-03-19 02:25:11

[Beep6581]

If there is a problem and the fix is the patch in #24, then commit it to default.  Default
will be merged into denoise sporadically until denoise is finished.  I don't see why
there is a conflict.

Reported by ejm.60657 on 2012-03-19 03:13:38

[Beep6581]

Code is moved to different file. Merge works within one file. 

Fix is already in default (about time of #28). 

Reported by GreatBull69 on 2012-03-19 04:32:23

[Beep6581]

OK, I see the problem.  Thanks.

Reported by ejm.60657 on 2012-03-19 12:36:22

[Beep6581]

Good! #24 is now fixed in "all" code.

Other reasons to link to 1052 are #7 (hope) and #25 (NR make problem visible). I dont
see them good reasons to keep block, but it dependence how persons think.

Still open problems are something like #33.

Reported by GreatBull69 on 2012-03-25 02:12:34

[Beep6581]

I have this problem!
It occurs in the current VisualBakery 4.0.9.50 build, and has existed in previous builds
for some time now.

It is visible in the RT image editor if the photo is viewed at 1:1. If its not viewed
at 1:1, the black squares are not visible.
The squares appear in random places around the image. At 1:1 view, if i drag the image,
the black squares will appear in different places.
Also, if i process the image to a JPG, every time i do so, even though no settings
have changed, the black squares will appear in different locations. 

It does appear to be related to noise reduction. If noise reduction is disabled, the
black squares do not appear.

The black squares are appearing in about 1/5th of my processed images.
Very very frustrating :(

PC is i7 with 16GB of RAm running Win7x64.
RAW's are CR2 from Canon 40D.

Can supply more info/raw/pp3 if required...

Reported by mwp@mwp.id.au on 2012-07-30 08:01:24

[Beep6581]

@ m...

you can try a built with the new NR 
http://rawtherapee.com/forum/viewtopic.php?f=1&t=3793&start=45

With 4.0.9.50, do you get rectangles even if luminance NR is set to >0 ??.

Reported by iliasgiarimis on 2012-07-30 09:55:01

[Beep6581]

Cannot reproduce bug using the two raw+pp3 files submitted in this thread in default
tip 4.0.9.104 3d928fc176bd nor in denoise tip 4.0.9.101 3c922f62295f.

Reported by entertheyoni on 2012-07-30 10:15:49

• Status changed: FixedPendingConfirmation
• Blocked on: #1052
• No longer blocked on: #1052

[Beep6581]

iliasgia...:
new NR 4.0.9.101 does not seem to have the problem.
4.0.9.50 does have the problem at any NR setting.

Reported by mwp@mwp.id.au on 2012-07-30 11:44:50

[Beep6581]

I think we can close it. If I'm wrong please re-open!

Reported by rinni@gmx.net on 2013-01-28 15:06:13

• Status changed: Fixed