CA auto-correction for RT

[Beep6581]

Originally reported on Google Code with ID 135

CA auto-correction code.  The auto-correction occurs before demosaic; to
invoke it, go to the demosaic dialog in Preferences and check the CA
auto-correction box.

Reported by ejm.60657 on 2010-06-04 03:48:51

---

• Attachment: CApatch.diff

[Beep6581]

Patch applied to staging for testing.

Reported by wyatt.olson on 2010-06-04 03:58:49

• Status changed: PatchSubmitted

[Beep6581]

Oops! a bug in a couple of parameters; here is a patch to fix that...

Reported by ejm.60657 on 2010-06-04 04:43:16

---

• Attachment: CA-bugfixpatch.diff

[Beep6581]

Why in CmakeLists.txt was
if (OPTION_OMP)
   find_package(OpenMP)
...
commented out?
This was added to allow compilation with OMP on Linux and disable it on other platform.

Reported by ffsup2@yahoo.it on 2010-06-04 11:58:24

[Beep6581]

Committed patch and uncommented OpenMP conditional.  Emil -- use -D OPTION_OMP=false
to disable OpenMP, no need to comment anything in the CMakeList.txt file.

Cheers

Reported by wyatt.olson on 2010-06-04 14:07:38

[Beep6581]

I commented it out because on my machine, cmake was aborting with complaints that
OpenMP was not found.  With the commented code in CMakeLists.txt, I was able to
build.  Apologies if this screwed things up for others, I just want to be able to
work on my stuff, and am willing to entertain expedient hacks to do so.

I will have another minor patch in a moment (parameter tweaks, overshoot protection
on edge corrections)...

Reported by ejm.60657 on 2010-06-04 14:46:52

[Beep6581]

NP, but you should be able to just use the cmake flag to remove it... it is working
fine on my OSX box at least, if yours does not work with the flag, please let me
know, as that would be a major bug (to my knowledge this works on all platforms, I
know for sure that someone has compiled a Windows version using it).

Reported by wyatt.olson on 2010-06-04 14:49:48

[Beep6581]

As promised, bugixes and code improvements for CA autocorrect (and also a couple for
AMaZE).

Reported by ejm.60657 on 2010-06-04 18:34:58

---

• _Attachment: CA_amz-bugfixpatch1.diff_

[Beep6581]

Pushed to staging.  Thanks!

Reported by wyatt.olson on 2010-06-04 18:37:17

[Beep6581]

I am getting somewhat poorer results for some images with CA autocorrection in RT
than I am getting with the same code applied in dcraw.  One possibility is different
order of processing.  In dcraw, scale_colors is applied before before CA correction
and thus before demosaic; this is a kind of WB preconditioning of the data which is
important.  

What is the order of processing in RT?  Is there any WB pre-conditioning of the data
before demosaic (there should be)?  If so, where is it in the code?

Reported by ejm.60657 on 2010-06-05 16:33:29

[Beep6581]

What is the status of this issue?  I know there has been many patches for Amaze and
/ or CA correction since the last post here.  If you feel this is working, please let
me know and I can update the ticket.

Cheers

Reported by wyatt.olson on 2010-07-11 19:42:12

• Status changed: PatchApplied

[Beep6581]

Yes the ticket can be closed.

Reported by ejm.60657 on 2010-07-12 03:04:56

[Beep6581]

Reported by wyatt.olson on 2010-07-12 03:06:33

• Status changed: Fixed

[Beep6581]

The last time i've tried, it still crashed, on Windows at least.

It only crash when using GCC optimizations... I'll check again as soon as i've finished
my current patch. If it's still ther, i'd like to talk to Emile to solve this problem
(if it's still there).

Reported by natureh.510 on 2010-07-12 12:29:40

[Beep6581]

Sounds good... I will leave the bug closed until I hear back from you, and we can decide
from there.

Cheers

Reported by wyatt.olson on 2010-07-12 14:23:44