Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.9k stars 323 forks source link

RT 4.0.8.3 not defaulting on DCP profile. #1296

Closed Beep6581 closed 9 years ago

Beep6581 commented 9 years ago

Originally reported on Google Code with ID 1312

When you have auto-match camera profile option selected it is suppose to default to
use the DCP profile .
But it seems by comparing pic and histogram it is using the ICC profile instead .

how I tested it .
I open image 1271.CR2   up, by default it has auto-match camera profile option enabled.
I then disable the blend hightlight with matrix . Now it should be using the DCP profile
so if I set/point to custom profile XSI.DCP one (Canon EOS Digital Rebel XSi.dcp) I
see a change in pic and histogram changes. If I now pick XSI .icc profile (Canon EOS
Digital Rebel XSi.icc) in custom it stays the same when I hit back to auto-match camera
profile option .

Click on Preferences > About > Version and paste all that here.
Branch: default
Version: 4.0.8.3
Changeset: 03d965613b60
Compiler: GCC 4.6.1
Processor: generic x86
System: Windows
Bit depth: 64 bits
Gtkmm: V2.22.0
Build type: RELEASE
Build flags:  -mtune=generic -O2 -DNDEBUG
Link flags:  -mtune=generic -mwindows -s -Wl,--large-address-aware
OpenMP support: ON
MMAP support: ON

Operating system (e.g. winXP-32bit, Ubuntu-11.10-64bit):
winXP-32bit SP3

 Here two screenshots that show auto-match camera profile and custom with XSI.dcp set
. notice difference in highlight at upper left corner .

http://i.imgur.com/w8kZ3.jpg

http://i.imgur.com/xa6lu.jpg

here is link to image 1271.cr2 (hopefully all links work).

http://min.us/mJDqP62ME

Reported by EdKieferLP on 2012-04-07 14:13:49

Beep6581 commented 9 years ago
Thanks for reporting Ed, got it, committed to DEFAULT already.

Reason was simply and upper/lowercase mismatch. Canons report as "Canon" while Nikon
reports as "NIKON", and since Michael and I are on Nikon we didn't have the bug.

Reported by oduis@hotmail.com on 2012-04-07 16:12:41

Beep6581 commented 9 years ago
This is not fixed in 4.0.8.10 XP 32 bit same as above .

Reported by EdKieferLP on 2012-04-18 17:11:19

Beep6581 commented 9 years ago

Reported by oduis@hotmail.com on 2012-04-18 17:54:12

Beep6581 commented 9 years ago
This is a very strange one now, which has nothing to do with the initial lowercase on.
Actually it does not seem to be in RT but below in the system. A function to search
works fine most of the time but fail on just a few ones.
I now do the search manually, and it's tested to fix it with the XSI.

Reported by oduis@hotmail.com on 2012-04-18 20:13:05

Beep6581 commented 9 years ago
not sure i understand problem but sounds like windows doesn't find path right ?

Anyway glad you can reproduce fine on your end and I will report back on next build
if things still not right .

Reported by EdKieferLP on 2012-04-18 20:32:15

Beep6581 commented 9 years ago
Not windows, somewhere in GCC/GTK compiler layer probably.
It works well with other Canon and Nikon files I tested, but it was blind for that
name (maybe more). Very strange. You run Win64? Then I could supply an EXE for you
to test.

Reported by oduis@hotmail.com on 2012-04-18 20:46:16

Beep6581 commented 9 years ago
Committed to DEFAULT.

Reported by oduis@hotmail.com on 2012-04-19 19:25:27

Beep6581 commented 9 years ago
Sadly no, I am on Win XP 32bit 

Reported by EdKieferLP on 2012-04-19 20:34:47