Munsell correction - Lab adjustements

[Beep6581]

Originally reported on Google Code with ID 1359

This patch adds the correction Munsell, to "Lab Adjustements"

Its action depends on the cursor "saturation", "brightness", "contrast" and the "curves"
luminance.
I changed "avoid color clipping" becomes "avoid color shift". This button enables the
correction Munsell

The software part of "vibrancy" is amended accordingly :)

Reported by jdesmis on 2012-05-09 06:48:04

---

• Attachment: munsell01.patch

[Beep6581]

Note: OMP is active. I check with "Process Explorer"

Reported by jdesmis on 2012-07-20 16:06:10

[Beep6581]

@Michael
Any crashlog to provide?

@Jacques
I'm on Windows7/64bits too and RT crash too, when a curve does auto-opens when unfolding
a tool section, or when resizing the tool pane while a curve is displayed, or when
closing an Editor tab. Unfortunatly the stack backtrace is not usefull here, but i
think it's related to Cairo::RefPtr misuse... I'm still working on it, but experienced
users are wlecome ;)

Reported by natureh.510 on 2012-07-20 18:13:12

[Beep6581]

Just edited a couple pictures with the patch, cannot repro the crashes. Resized the
panel and unfolding a section them, now problem here.
BTW: Does any of you compile with -ffast-math ? It has been reported to cause crashes
in tone mapping. Read some articles on the web, it seems to be a troublemaker.

Reported by oduis@hotmail.com on 2012-07-20 20:13:00

[Beep6581]

PS: This is a sample with the patch, only Raw White Point for base exposure and the
new Lab correction for punching colors and curves.
The colors are simply amazing :-)http://www.visualbakery.com/RawTherapee/Download/DSC_8058.jpg
Thanks Jacques & Hombre.

Reported by oduis@hotmail.com on 2012-07-20 20:23:11

[Beep6581]

Could you show a version with all the tweaks except for those introduced by this patch?
So no L*a*b*, no CC, no CH, no vibrance, etc.

ps. crashes fixed, confirmed in IRC, thank you Hombre!

I'm still far from having a solid grasp on this, but colors do seem to get a quality
I couldn't produce before. Tweaking colors in this way is something new to me and I'm
still learning. I'd appreciate all advice, guides, tutorials on this you can offer
:]

Reported by entertheyoni on 2012-07-20 22:40:05

[Beep6581]

Holy Father! I promise to only use the vector::at() method instead of the [] operator!
:) A loop in MyFlatCurve::interpolate was accessing one value beyond the limit :/

Patch committed!

Thanks again Jacques for this great new features, and to the betatesters.

Reported by natureh.510 on 2012-07-20 22:51:45

[Beep6581]

Reported by natureh.510 on 2012-07-20 23:02:29

• Status changed: Fixed

[Beep6581]

Thank you Jacques and Hombre!

Reported by entertheyoni on 2012-07-20 23:03:02

• Labels added: Type-Enhancement
• Labels removed: Type-Defect

[Beep6581]

I'm leaving this morning in the mountains with my 2 little sons, and I am very pleased
that this patch can be updated.
Thank you all for your cooperation.

And thank you to Hombre, both of us have made a cooperative effort - adding our skills
- which is an example for the project RawTherapee  :)

Reported by jdesmis on 2012-07-21 05:15:12

[Beep6581]

Yeah, nice collaboration, but i'm sure that other developpers do collaborate as well
;)

Reported by natureh.510 on 2012-07-21 10:33:00

[Beep6581]

> Could you show a version with all the tweaks except for those introduced by this patch?
Sorry DrSlony, I must admit that I fooled myself: I struggled getting the colors right,
and editing it a second time with the patch the colors came out great. However the
difference was not due to the effects of the patch. The patch is still good and improves
colors a bit, but in this particular image edit, the differences are only subtle.

Reported by oduis@hotmail.com on 2012-07-21 21:41:46

[Beep6581]

I was supposed to be asleep for 90 minutes now, but here I am sitting and in awe of
how awesome controlling portrait skin tones with this is :D Well done!

Reported by entertheyoni on 2012-07-23 23:13:00

[Beep6581]

I put on my website a summary explanation of the new features (in French)

http://jacques.desmis.perso.neuf.fr/RT/Labadj_vibr.html

Reported by jdesmis on 2012-07-29 07:21:42

[Beep6581]

Thanks, Jacquez.

Would it be possible to add LSH adjustements to RT? I find that working on skintones
using Lab is very difficult, as chromaticity changes on darkened tones are difficult
to control. In LSH this should not be a problem when adjusting L curve as chromaticity
will be preserved.

Reported by michaelezra000 on 2012-07-29 11:42:43