Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.77k stars 314 forks source link

Square box artifacts w/Lumix GH2 #1347

Closed Beep6581 closed 9 years ago

Beep6581 commented 9 years ago

Originally reported on Google Code with ID 1363

Describe the problem and how to reproduce it.

Erroneous artifacts resembling black squares with dotted white outlines in certain
images.

Camera: Panasonic Lumix GH2

Not sure what causes it - sometimes it seems to be the hot/dead pixel detection, sometimes
another control in the demosaicing tab. When it occurs, it stays in the same place(s)
for each image and settings, but changing settings might make artifacts move in the
image.

Click on Preferences > About > Version and paste all that here.

Branch: 
Version: 
Changeset: 
Compiler: GCC 4.7.0
Processor: undefined
System: Linux
Bit depth: 64 bits
Gtkmm: V2.24.2
Build type: Release
Build flags: -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4
-D_FORTIFY_SOURCE=2
Link flags:  -Wl,-O1,--sort-common,--as-needed,-z,relro,--hash-style=gnu
OpenMP support: ON
MMAP support: ON

Operating system (e.g. winXP-32bit, Ubuntu-11.10-64bit):

Arch linux - the above is the regular package.

Problem with a raw photo? ALWAYS provide a link to it for us to download.

http://min.us/mW3yOuT61 - the screenshot is a 1:1 crop from the failed TIFF output.

Reported by avis.prede on 2012-05-14 09:47:59

Beep6581 commented 9 years ago
I managed to reproduce the black square box, but not where it's located on your screenshot
while still using your PP3 file.

Disable Sharpen and Microcontrast first, they doesn't seem to be relevant here, then
scale to 1:1 and pan the image until you see a black square.

Some facts if you followed the previous steps:
 - Disable the Denoise tool only, then the black square is removed
 - Disable the EPD tool only, then the black square is removed
 - Pan the preview only, then the black square is removed
 - In "ImProcCoordinator::updatePreviewImage", "ipf.EPDToneMap" is called before "ipf.dirpyrdenoise"

This lead to the conclusion that the EPD tool create a situation where that lead dirpyrdenoise
to produce a black square. Each tool alone doesn't produce this artifact.

So this one is really not for me, but i hope this helps...

Reported by natureh.510 on 2012-06-03 13:16:27

Beep6581 commented 9 years ago
Fixed long ago.

Reported by entertheyoni on 2014-10-31 20:12:32